deux-trios• 40
@deux-trios
Posted
Design:
- At first glance the colour of the main card container should be white, and the scale is bigger than the original design but it's a nitpick
- Overall the design is 1 to 1. Good job
- The scale of the card shrinks when you zoom out. It would be great if it's static so the content can be seen by people who don't know that the their browser is zoomed out
- The layout is good on every screen size
HTML
- I don't like the spaces between the code.
- I also don't like how the <footer> tag is indented. I think it's on par with main since they are both landmark elements
Overall The solution doesn't go too far from the design. I give it a 8/10
Marked as helpful
1
Silo de Menezes• 20
@Silo30
Posted
@deux-trios
Thanks for the feedback and critcism!
Design:
- I don't remember how i messed up the color, but i will correct that as soon as I can. The size is something i will take some tries to get the right one, but it shouldn't be too hard. I was basing it on the deskop design example and trying to match it as close as possible, but i guess that's not the best way to do it.
- It makes me very happy to heart that. Thanks.
- Thanks for the tip. I didn't think of that. Will make it static soon.
- Good to hear. I use a extension called Resposive Viewer to check it web pages will look in different screen sizes.
HTML
- I usually leave these spaces to make it easier to read different code sections, but i understand that can look bad for others.
- That's fair. Will try to adjust it later.
Again thanks for your criticism! It gave a lot to think about my project.
0
