All comments

• 

  이은지 / Angie Lee•30

  @angielxxSubmitted about 2 years ago

  • Are my class names appropriate?
  • I don't know how to organize CSS codes.

  

  01. Product preview card component solution

  2

  80
  

  Benny•180

  @dbenny1Posted about 2 years ago

  Awesome job.

  You should try to reduce the use of divs. Use proper semantic HTML like section, article etc.

  I advise you use divs for design purpose.

  For my class names, I use camel case.

  1
• 

  Francesca•50

  @francxrussoSubmitted about 2 years ago

  Hello everyone! This is my second project on Frontend mentor, I am still not confident with rem em .. I tryed my best. Every kind of help or advice is accepted!

  Thank you

  

  QR code component challenge

  2

  30
  

  Benny•180

  @dbenny1Posted about 2 years ago

  Great job Francesca! You did a great job.

  You should indent your code properly next time. I had a bit difficulty read through your HTML file. Excellent job nevertheless. You're on the right track.

  Marked as helpful

  0

  This comment has received 1 replyShow
• 

  cattheelephant•10

  @cattheelephantSubmitted about 2 years ago

  -What did you find difficult while building the project? -Which areas of the code would you improve on? -Any advice on best practices and resources for future projects?

  

  Responsive QR Code Component Using HTML & CSS

  3

  30
  

  Benny•180

  @dbenny1Posted about 2 years ago

  Great job! You should use semantic HTML next time. It helps a lot for accessibility (like screenreaders etc.). Instead of,

     `<div class="main"></div>
     <div class="footer"></div>`
  

  You can use,

     `<main></main>
     <footer></footer>`
  

  Plus, your img tag should have an alt attribute.

  Marked as helpful

  0

  This comment has received 1 replyShow