Design comparison
Solution retrospective
Hello everyone! This is my second project on Frontend mentor, I am still not confident with rem em .. I tryed my best. Every kind of help or advice is accepted!
Thank you
Community feedback
- @dbenny1Posted about 2 years ago
Great job Francesca! You did a great job.
You should indent your code properly next time. I had a bit difficulty read through your HTML file. Excellent job nevertheless. You're on the right track.
Marked as helpful0@francxrussoPosted about 2 years ago@dbenny1 Yes, you're right! I always forget to indent my code!
Thank you so much, next time i'll keep that in mind
0 - @correlucasPosted about 2 years ago
👾Hello Francesca, congratulations on your first solution!
I’ve some suggestions for you:
Your solution is perfect! There's not much to add here, if you want to improve it even more you can delete the
div
containing the text, in this case the content can stand alone inside main (img h1 and p) without no need of other blocks. To reduce the css you can select the h1 and paragraph with the direct selector these two elements instead of using class.✌️ I hope this helps you and happy coding!
Marked as helpful0@francxrussoPosted about 2 years ago@correlucas Thank you for your suggestion!
I appreciate that.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord