01. Product preview card component solution

Community feedback

• 

  Benny•180

  @dbenny1Posted about 2 years ago

  Awesome job.

  You should try to reduce the use of divs. Use proper semantic HTML like section, article etc.

  I advise you use divs for design purpose.

  For my class names, I use camel case.

  1
• 

  Kostya Farber 🧟‍♂️•220

  @kostyafarberPosted about 2 years ago

  Hey there! 👋

  Really great solution. It looks pixel perfect! Your CSS is very structured and looks clean.

  Just a couple of suggestions:

  • Try adding your CSS document wide variables to the :root. It's best practise and looks a lot cleaner.
  • Make sure to remove any comments! The index.html has some commented out code. It will make it easier to read and more 'production ready'.
  • If you want follow a convention for naming your CSS look at the BEM convention. They provide an intuitive way to name your elements to make their meaning semantic. Check it out here.

  Really great work though! 🚀

  Happy coding.

  If you found my comment helpful please mark it as helpful 🙂

  0