@Benjamin-odekinaSubmitted about 1 year ago
Hi everyone, it was worth giving a try and it helped me practice my flex box tutorials well. pls critize
P
D3V
@d3vaqaAll comments
- @d3vaqaPosted about 1 year ago
well done. just the height looks so different compared to the original design. if you could adjust the height. it will be looking much nicer. thanks
Marked as helpful1 - @HarshJohnSubmitted over 2 years ago
Check out my code and suggest to me how can I improve from here. What mistakes did I commit on my way? And other suggestions, please.
@d3vaqaPosted over 2 years agowell done, just checkout the accessibility issues as they are pretty important
0 - @JoanFuentes1981Submitted over 2 years ago
Me resulto sencillo, pero seguramente muchos encontraran varias cosas que corregir o comentar, bienvenidos los comentarios que ayuden a crecer.
Saludos
@d3vaqaPosted over 2 years agoGood job! in terms of accessibility there are some issues that I have noticed
1 - instated of <div class="cuadro-interno"> it would be much better to use <main class="cuadro-interno"> 2 - in <img src="" alt ="" > in this case its necessary to fill the alteration for your image as => <img src="" alt ="QR Code" > 3 -change <p class="texto-uno"> to <h1 class="texto-uno"> 4 - chuck the <div class="attribution"> class outside your <div class="cuadro-interno"> and put it inside footer tag.
thanks
Marked as helpful0 - @d3vaqaSubmitted over 2 years ago
