Skip to content
Submitted over 2 years ago

HTML CSS

JoanFuentes1981•20
@JoanFuentes1981
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Me resulto sencillo, pero seguramente muchos encontraran varias cosas que corregir o comentar, bienvenidos los comentarios que ayuden a crecer.

Saludos

Community feedback

  • D3V•120
    @d3vaqaPosted over 2 years ago

    Good job! in terms of accessibility there are some issues that I have noticed

    1 - instated of <div class="cuadro-interno"> it would be much better to use <main class="cuadro-interno"> 2 - in <img src="" alt ="" > in this case its necessary to fill the alteration for your image as => <img src="" alt ="QR Code" > 3 -change <p class="texto-uno"> to <h1 class="texto-uno"> 4 - chuck the <div class="attribution"> class outside your <div class="cuadro-interno"> and put it inside footer tag.

    thanks

    Marked as helpful
    0
    JoanFuentes1981•20
    @JoanFuentes1981Posted over 2 years ago

    @d3vaqa Thank you so much your tips, in this moment proced. tks

    0
    D3V•120
    @d3vaqaPosted over 2 years ago

    @JoanFuentes1981 well done

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord