XYshop• 100
@XYshop
Submitted
Dilip Kumar
@curiousdilip
All comments
- Dilip Kumar• 350
@curiousdilip
Posted
Your solution looks good and it is responsive too.
i would recommend that you add correct for your github link "https://github.com/XYshop.github.io" --> "https://github.com/XYshop/XYshop.github.io"
0 - Mik2nd• 350
@mik2nd
Submitted
What are you most proud of, and what would you do differently next time?
i finish
What challenges did you encounter, and how did you overcome them?
it was first time working with grid and responsive media very confusing, not too bad for this chalenge.
What specific areas of your project would you like help with?
maybe i too much using max width / height ,i wonder can find another way too keep the item size.
Dilip Kumar• 350@curiousdilip
Posted
your solution looks good, but there are some solutions/guidance for you
- background color is different
- box shadow is different
i will recommend that u should use the style-guide.md file for color, font, shadows
0 - PPaul Olynek• 330
@ePaulo
Submitted
What are you most proud of, and what would you do differently next time?
Learned how to use the tag to setup different images for different view-screen sizes. Coded the HTML based on the desktop design, then coded the CSS mobile before adding a media query to add code changes for the desktop layout.
What challenges did you encounter, and how did you overcome them?
Had to learn how to use different images for different view-screen widths.
What specific areas of your project would you like help with?
How (if possible) to force side-scrolling once the mobile view-screen width reaches the min-width setting... or is there no side-scroll bar displayed on mobile screens?
Dilip Kumar• 350@curiousdilip
Posted
This comment was deleted
0 - Mik2nd• 350
@mik2nd
Submitted
What are you most proud of, and what would you do differently next time?
i finish
What challenges did you encounter, and how did you overcome them?
i cant make tables work, so i done with div and span
What specific areas of your project would you like help with?
i cant make table, maybe i fix that later on
Dilip Kumar• 350@curiousdilip
Posted
Your recipe page looks good but there are some scope of improvement like, for eg: you should have added some spacing on top and bottom of the box containing the recipe content.
0 - devEduSousa• 330
@devEduSousa
Submitted
Dilip Kumar• 350@curiousdilip
Posted
the code looks good
you should have added .container height of 100vh so that it would have aligned in the center.
regards Dilip
Marked as helpful
0 - Zwelihlecomet2• 90
@Zwelihlecomet2
Submitted
What are you most proud of, and what would you do differently next time?
i am mostly proud that my media queries are a little bit getting better
What challenges did you encounter, and how did you overcome them?
media queries..i always face challenges with media queries
What specific areas of your project would you like help with?
mostly media queries.
Dilip Kumar• 350@curiousdilip
Posted
Congrats on your 3rd Challenge!
However there are some improve needed in your code as i can see from the screenshot, you can reduce padding bottom
Regards Dilip
0 - ibnu-jemal• 150
@ibnu-jemal
Submitted
What are you most proud of, and what would you do differently next time?
.
What specific areas of your project would you like help with?
....
Dilip Kumar• 350@curiousdilip
Posted
hi ibnu-jemal, Congrats on completing your 1st challenge on Frontend Mentor,
*{ margin: 0; padding: 0; }you should have added box-sizing:border-box as it will allow you to include the padding and border in an element's total width and height.
Marked as helpful
0
