@kyla42Submitted over 2 years ago
KamRan
@comendrunAll comments
- @comendrunPosted over 2 years ago
Hi your solution looks great! I really liked that you could match the style exactly like the original design itself! wonderful! but I noticed something I wanted to share with you. You set the height for the main to be 100vh and that's ok, but it can cause problems in some display modes. Probably it's better to set it to be min-height: 100vh; and that would solve the problem. I would like to hear from you about this if you know something that certainly I don't know besides that, I really liked your solution, congrats!
Marked as helpful0 - @vanzasetiaSubmitted over 2 years ago
I've done another challenge! š
It's hard to find the exact RegEx that I want to validate user inputs. For the email RegEx, I already created by myself so I did just copy-paste from previous solution. For the name RegEx, I created a RegEx where the user's first name and last name should have at least a vowel letter and two characters long. Password RegEx that I wanted was difficult to find. However, I finally found a gist that contains the password RegEx that I wanted.
I added two new features such as
- Users are able to toggle the password visibility so they can see what they've typed.
- Users can see the password length so they don't have to count it by themselves.
These features were added based on my users' stories.
I have no questions however, any feedback is appreciated.
Any questions on the technique that I'm using are welcome! š
Also, if you have finished this challenge and would like me to give feedback on it, please include a link to your solution. I would be glad to help you! š
Thanks!
@comendrunPosted over 2 years agoHi Vanza. thank you for your helpful feedback and comments that you write on your projects. I learned a lot from them and also they helped me guide my attention to the right place. Here's my solution, it's not as complete as yours, but I tried and spent a good time on it :
https://www.frontendmentor.io/solutions/intro-components-using-html-cssflexbox-also-javascript-validation-LbAIqzOu9e
1 - @Grillo26Submitted over 2 years ago
Ignored tags, and i forget put wallpaper
@comendrunPosted over 2 years agoHey Carlos. I hope you're doing well. your solution is good overall but I think you should regenerate the screenshot for your solution because the first one is a little messed up I visited your solution page and it was fine. so you can easily regenerate the screenshot for it to have a better one. wishing you the best of luck
Marked as helpful0 - @NazemrapSubmitted over 2 years ago
In general no problem, just one little thing bother me is the fact that when i'm playing with the dev tools at some width the top part goes overflow.
@comendrunPosted over 2 years agoHi! I just wanted to say I really liked your solution. Wishing all the best for you my friend.
0 - @DarrickFauvelSubmitted over 2 years ago
Hi mentors! š
I just completed this solution. I'm using a couple media queries to handle the shifting of the socials bubble/tooltip on minimum screen widths 730px & 900px. Maybe there is a better method? š¤·āāļø
Please let me know if I missed anything, or I could do something better.
Thanks
:Darrick
@comendrunPosted over 2 years agoIt really looks perfect Derrick. I accidentally came across your solution and I really loved it. Also, I cloned it as I really struggled in that social media pop-up part and couldn't make it right. I'm sure i can learn a lot of things from your solution. thank you again
1 - @comendrunSubmitted over 2 years ago
Hi I tried my best to position the background pattern for the desktop perfectly but I couldn't make it 100% right for different screen sizes. I would appreciate any advice or a different approach to this problem. Thank you
@comendrunPosted over 2 years agodear Vanza (@vanzasetia) can you please help me with this? I get a lot of accessibility problems in ReactJS apps and I don't why is it. I tried to read the suggested document about it but I couldn't understand, unfortunately. they're about landmarks on the page
0 - @Ogshabzy23101Submitted over 2 years ago
all feedbacks are welcome
@comendrunPosted over 2 years agoGreat Job Damilola, I accidentally saw your solution, and honestly, it's a good one. Good Luck with other challenges!
1
