Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component

NC 420

@kyla42

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

KamRan 370

@comendrun

Posted

Hi your solution looks great! I really liked that you could match the style exactly like the original design itself! wonderful! but I noticed something I wanted to share with you. You set the height for the main to be 100vh and that's ok, but it can cause problems in some display modes. Probably it's better to set it to be min-height: 100vh; and that would solve the problem. I would like to hear from you about this if you know something that certainly I don't know besides that, I really liked your solution, congrats!

Marked as helpful

0

NC 420

@kyla42

Posted

@comendrun Hi, thank you for your comment! I've just googled it and you are right about the height setting, seems like it might cause problems with iOS safari.. I'll modify the code. Thanks a lot for your helpful tip :)

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord