Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • P

    @gusanchefullstack

    Submitted

    What are you most proud of, and what would you do differently next time?

    NA

    What challenges did you encounter, and how did you overcome them?

    NA

    What specific areas of your project would you like help with?

    NA

    @chenmeister

    Posted

    This solution looks almost exactly like the design. What I would suggest is to add the margin for the card element to be all around and evenly so that the bottom part doesn't just get stuck to the end. (Ex. use margin: 10px auto in your container section). Otherwise entire site looks good in general.

    0
  • @chenmeister

    Posted

    Overall this solution is very clean and looks almost exactly like the design itself. However, after looking at the source code there are some modern HTML5 elements and practices you can use.

    1. Instead of using div for the card element, use article or section if possible
    2. Maybe group the image, name and location into one section for easier CSS adjustment

    Marked as helpful

    0
  • P
    Tai Jones 40

    @ProgramJones

    Submitted

    What are you most proud of, and what would you do differently next time?

    I'm proud of how I learned how to scalably structure my CSS code. Next time I'll be sure to set my CSS files with the lessons learned from this project.

    What challenges did you encounter, and how did you overcome them?

    The only frustrating thing was a typo in the variable font relative path that took three hours to troubleshoot. Next time I won't put it past myself to make mistakes like that.

    What specific areas of your project would you like help with?

    It'd be nice if I could figure out why there's space between the SVG and the yellow label below it.

    @chenmeister

    Posted

    Overall the solution looks very good. Very organized and close to the jpeg provided.

    0
  • @chenmeister

    Posted

    Overall this solution looks good and fulfills the task. However, when putting in mobile mode via chrome dev tools, the card and the QR code looks very small. Code wise, the best way is to utilize flexbox if possible as it requires less CSS code and makes your webpage more adaptable.

    0