Skip to content
OverviewSolutions
35
Comments
45
Bhremada Fevreano
@boedegoat

All comments

  • Bhremada Fevreano•1,395
    @boedegoatPosted about 2 years ago

    Nice one @AditNovadianto. One thing is missing. You should make the mobile navbar close when the user clicks outside. And don't forget to fix the accessibility issues. As always keep it up and enjoy coding 🔥

    1
  • Bhremada Fevreano•1,395
    @boedegoatPosted about 2 years ago

    Nice one @AditNovadianto. I like the blur transparent effect on the mobile nav opened. Also, try to fix all those accessibility issues. Keep it up 🔥

    Marked as helpful
    1
  • Gilang Aditya•425
    @madegilangadityaSubmitted over 2 years ago

    Still need a lot improvement for the code especially for the modal popup and when click the pledges you want. Also need improvement for the react useState best practice. Any suggestion will be very appreciated.

    Responsive landing page using react JS

    1
    Bhremada Fevreano•1,395
    @boedegoatPosted over 2 years ago

    Good work @madegilangaditya. The design is pretty neat and responsive as well. To get rid of those accessibility issues, you can wrap all of your components with a <main> tag. Also, I think it would be nicer if you make clicking outside will close the mobile menu or modal. Other than that, keep it up and enjoy coding.

    0
  • Bhremada Fevreano•1,395
    @boedegoatPosted over 2 years ago

    Very good @AditNovadianto!

    Marked as helpful
    0
  • Bhremada Fevreano•1,395
    @boedegoatPosted over 2 years ago

    Great job @AditNovadianto, I like how you implement those animations to make the site more live. Keep it up and enjoy coding 🎉

    Marked as helpful
    0
  • Bhremada Fevreano•1,395
    @boedegoatPosted over 2 years ago

    Nice work @AditNovadianto, Just remainder, kindly check the issues there and there is some kind of weird gap in top part, try remove the vertical padding in your container. Other than that, keep it up and enjoy coding

    Marked as helpful
    1
  • Bhremada Fevreano•1,395
    @boedegoatPosted over 2 years ago

    Nice work @AditNovadianto, as above comment said, try fix those accessibility and layout issues. Other than that, just keep doing more project especially with react so you can get more better and better.

    Keep it up and enjoy coding

    Marked as helpful
    0
  • Bhremada Fevreano•1,395
    @boedegoatPosted over 2 years ago

    Great work @AditNovadianto. The result looks really great and its responsive as well. I think you getting better. So keep it up and enjoy coding.

    Marked as helpful
    1
  • Bhremada Fevreano•1,395
    @boedegoatPosted over 2 years ago

    Great work @AditNovadianto. You've done fantastic work.

    Just remainder, take a look at your accessibility issue, try to fix it by wrapping your entire app with <main> tag. Also, I think that mobile menu should be closed when user click outside it.

    Other than that, keep it up and enjoy coding

    Marked as helpful
    1
  • Bhremada Fevreano•1,395
    @boedegoatPosted over 2 years ago

    Great work @besttlookk. The result looks really great.

    But there is one small issue, the mobile menu is kinda pushed to the right on <375px screen size so it's not responsive yet.

    I think it's because the inset property in MobileNavigation_Wrapper, on what I have tried before, deleting inset and adding these styles may fixed the issue :

    top: 0;
right: 0;
width: 180px;
height: 100%;

    Other than that, keep it up and enjoy coding

    0
  • Bhremada Fevreano•1,395
    @boedegoatPosted over 2 years ago

    Great work @AditNovadianto. Congratulations for finishing another challenges.

    Some of your issues have been explained by @Prabhash Ranjan. So I suggest you to learn more about the usage of max-width to make your layout more responsive.

    Other than that, keep it up and enjoy coding !

    Marked as helpful
    1
  • AditNovadianto•1,040
    @AditNovadiantoSubmitted over 2 years ago

    I will be happy to hear any feedback and suggestion!!!

    CSS Flexbox

    1
    Bhremada Fevreano•1,395
    @boedegoatPosted over 2 years ago

    Good job @AditNovadianto

    One thing to note, you might use <main> tag to be the container of your app in order to fix those accesibility issue.

    Other than that, keep learning and enjoy coding ☕

    Marked as helpful
    0