CSS Flexbox, SASS

Community feedback

• 

  Bhremada Fevreano•1,395

  @boedegoatPosted over 2 years ago

  Great work @AditNovadianto. Congratulations for finishing another challenges.

  Some of your issues have been explained by @Prabhash Ranjan. So I suggest you to learn more about the usage of max-width to make your layout more responsive.

  Other than that, keep it up and enjoy coding !

  Marked as helpful

  1

  ---

  

  AditNovadianto•1,040

  @AditNovadiantoPosted over 2 years ago

  @boedegoat Thankyou @boedegoat for your advice!!!

  0
• 

  Prabhash Ranjan•2,540

  @besttlookkPosted over 2 years ago

  Hi, Everything looks great. There are few things i like to point out:

  1. on Focing the input the rest of the UI shifts a bit. That is because you have added border on focus. To avoid that shift add border on normal state too but with transparent color.

  2.You should wrap the content with some wrapper as in some breakpoints content is touching the screen, also input and button are not aligned to the center . This is what i do normally

  main {
   width: 90vw;
   max-width:1280px;
   margin-inline: auto;
   }
  
  @media (min-width:1200px){
    main{
       padding-inline: 1rem;
    }
  }
  

  3. Add error state when user click on "notify me" without adding any url

  Good Luck

  Happy Coding

  Marked as helpful

  1

  ---

  

  AditNovadianto•1,040

  @AditNovadiantoPosted over 2 years ago

  @besttlookk thankyou for your advice and i will fix it!!!

  1