@beniusis
@Vidottizzz
Submitted
I did it, but i would like if someone help me, because if i open more than 1 option the text overextend the card itself, and i think that if i could create a function that make just one option avaiable to open at time, but i dont know how to do it, can someone helps me with it?
@beniusis
Posted
Hey 👋 Congratulations on completing the challenge!
The text overflows because you have set the card's height as 34rem. To fix that, you can set height: fit-content.
@itsU-K
Submitted
@beniusis
Posted
Hey 👋 Good job on completing the challenge!
A few things worth mentioning:
<h1> tag per page. You can read more about the accessible heading structure here.alt attributes for images. It is read by screen readers for people with visual impairments and is better for SEO. You can read more about it here.<main>, <footer>, <header> to improve accessibility and achieve better organization. For example, switch <div class="containt"> to <main class="containt">.I hope the feedback was helpful. Happy coding! 😀
Marked as helpful
@J3r3mia
Submitted
Struggling with centering my component when its in desktop view.
@beniusis
Posted
Hey 👋 Good job on finishing the challenge! To answer your question, you can switch body property height: 100% to min-height: 100vh to center the component.
Marked as helpful
@ChaosBlitz404
Submitted
okay i dont know some stuff
thats all.all feedbacks are welcome thanks!
@beniusis
Posted
Hey 👋 Good job on finishing the challenge! I know there are stuff to be corrected, so here's a few things worth mentioning:
letter-spacing property in CSS instead of using non-breaking space entities here: <p class="perfume"> P e r f u m e</p>.<strike> tag is not supported anymore in HTML5. Instead use <del> tag for the previous price of the product.<br> tags just for the sake of leaving gaps between the different elements. Read more about its purpose here.<main>, <header>, <footer> to improve accessibility and achieve better organization.<div> and use flexbox property align-items: center. You can read more about the usage of flexbox here. While reviewing your code, I noticed that you overuse position: absolute property. Personally, I would rather learn flexbox and implement its usage for better experience.Happy coding! 😀
Marked as helpful
@Jonndev25
Submitted
I learned little about responsive design.
Any feedback will help me to improve. Thanks
@beniusis
Posted
Hey 👋 Good job on completing the challenge! A few things that caught my eye:
min-height properties for body? I think you forgot to delete one.1440px (at 1441px and up) the layout is shown as for mobile one.Marked as helpful
@manjubhaskar02
Submitted
This is my solution for Age-Calculator-App.
Welcoming every suggestion for improving this solution.
@beniusis
Posted
Hey. Great job on completing the challenge! I did not look through the technicalities but judging from the site preview, calculation of the age is wrong. For example, if you put the date as January 5th of 2024, the result you get is as follows: -1 years -4 months -22 days. The inputs for day and month are switched.
Marked as helpful
