Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

perfume site thing using css and html

@ChaosBlitz404

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


okay i dont know some stuff

  • how do i make the $169.99 center with the big $149.99 text
  • how do i make the web responsive like two different version for mob and desktop?

thats all.all feedbacks are welcome thanks!

Community feedback

beniusis 400

@beniusis

Posted

Hey 👋 Good job on finishing the challenge! I know there are stuff to be corrected, so here's a few things worth mentioning:

  • You can set letter-spacing property in CSS instead of using non-breaking space entities here: <p class="perfume"> P&nbsp; e&nbsp; r&nbsp; f&nbsp; u&nbsp; m&nbsp; e</p>.
  • <strike> tag is not supported anymore in HTML5. Instead use <del> tag for the previous price of the product.
  • You should not use <br> tags just for the sake of leaving gaps between the different elements. Read more about its purpose here.
  • You should use semantic elements like <main>, <header>, <footer> to improve accessibility and achieve better organization.
  • To vertically align current price and old price elements, you could wrap them both in one <div> and use flexbox property align-items: center. You can read more about the usage of flexbox here. While reviewing your code, I noticed that you overuse position: absolute property. Personally, I would rather learn flexbox and implement its usage for better experience.
  • To create a responsive web page, you can use media queries and set different properties to different elements. Here's an article with basics of responsive web design.

Happy coding! 😀

Marked as helpful

4

@ChaosBlitz404

Posted

thx for the feedback! @beniusis

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord