@Blackpachamame
Posted
Greetings! you have done a great job š
š Some accessibility and semantics recommendations for your HTML
- To improve the semantics of your HTML, you can change your
<div class="attribution">
to a<footer class="attribution">
- The
attribution
should go outside themain
- In your styles, you have put
Body
instead ofbody
. In theory, this has no effect, but it is preferable for it to bebody
š Some suggestions
- You can use
object-fit: cover
in yourimg
, this will make the image fill the entire container maintaining its aspect ratio. More info - If your
parent-container
already has amargin
, thepadding
of yourbody
is unnecessary - Instead of using
margin
to center your content in the center of the screen, you can use theflexbox
properties in thebody
:
body {
min-height: 100vh;
display: flex;
justify-content: center;
align-items: center;
font-size: 15px;
font-family: var(--main-font);
font-weight: var(--main-font-weight);
background-color: var(--Very-dark-blue);
/* padding: 3rem; */
flex-direction: column;
gap: 20px; /* Separate the main from the footer */
}
- With these changes you no longer need a
margin-bottom
in yourparent-container
nor amargin-top
in thefooter
Marked as helpful