Skip to content
OverviewSolutions
15
Comments
4
Aviral Sharma
@aviralsharma07

All comments

  • Aviral Sharma•220
    @aviralsharma07Posted about 2 years ago

    Hey, Congratulations on creating this project. Here are my few suggestions for you.

    • Use semantics HTML Tags like <article> to wrap card content then <div>
    • You don't need to wrap the <img> inside an <div> it is not required.
    • Write your CSS in a separate file named styles.css and link it to HTML in the <head> section.
    • Use max-width: 25ch instead of width for .text-class
    • There is no need for a Flex basis multiple times in this project. Refer to this to learn Flexbox: https://css-tricks.com/snippets/css/a-guide-to-flexbox/
    • Use margin-top for spacing between <p> and heading not padding-top.

    Hope it helps. Keep up the good work!

    Marked as helpful
    0
  • Aviral Sharma•220
    @aviralsharma07Posted about 2 years ago

    Hey Deepanshu, Congratulations on completing this Project. Here are a few suggestions for you:

    • Every page must have an <main> Element. Unnecessary <div> is not required. Use <main class="container"> instead of <div class="container">
    • Try to use an HTML semantics tag by wrapping the Card in <article> tag instead of a <div>
    • Use <h1> instead of <h3>
    • Use a <footer> tag for Page Footer than <div>
    • in the .container class use min-height instead of just height.

    Everything else looks fine to me. Hope it helps. Great work, keep it up!

    Marked as helpful
    0
  • Aviral Sharma•220
    @aviralsharma07Posted about 2 years ago

    Hey Enrica, Congratulations on completing this project!

    Here are a few suggestions:

    • Write HTML Semantics tags to write clean code. Use an <footer> instead of a <div>.
    • <article> Tag itself can be used as a container for Cards. You can remove the <div> tag you have inside it.
    • Provide an "alt text" for <img> element.
    Marked as helpful
    0
  • Aviral Sharma•220
    @aviralsharma07Posted about 2 years ago

    Hey! Great Work, Here are a few suggestions to improve your Code:

    1. Use Semantic HTML Tags Like Article instead of section as everything under article has a separate meaning. Before deploying the project use W3 HTML and CSS Validators to avoid syntax errors.
    2. Write your CSS in a separate file and link it inside head
    3. Don't use <br> element between Text. Instead, use min-width:25ch accordingly for text.
    4. Try writing clean code by reducing what is not required. You can remove div with the class "qr-wrapper" since you already use the body as a Flex container.
    5. Use an img Tag and write an alt text for it.

    Best of Luck, Hope it helps !!

    0