Submitted about 2 years ago
Responsive QR code component Page Using CSS Flexbox
@deepanshu1894
Design comparison
SolutionDesign
Solution retrospective
Please Give Feedback about This Page. Any Feedback is appreciated
Community feedback
- @PTMeenPosted about 2 years ago
Hello friend, you did a great job! just increase the padding a bit to make it look closer to the design.
Happy coding ✌
Marked as helpful1 - @aviralsharma07Posted about 2 years ago
Hey Deepanshu, Congratulations on completing this Project. Here are a few suggestions for you:
- Every page must have an <main> Element. Unnecessary <div> is not required. Use <main class="container"> instead of <div class="container">
- Try to use an HTML semantics tag by wrapping the Card in <article> tag instead of a <div>
- Use <h1> instead of <h3>
- Use a <footer> tag for Page Footer than <div>
- in the .container class use min-height instead of just height.
Everything else looks fine to me. Hope it helps. Great work, keep it up!
Marked as helpful0@deepanshu1894Posted about 2 years ago@aviralsharma07 I'll Surely will implement your suggestions in my next project, thank you.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord