Skip to content
OverviewSolutions
26
Comments
6

Avatarfreak

@avatarfreakIndia655 points

Full stack web developer. Certificate earned from freecodecamp: https://www.freecodecamp.org/avatarfreak

Latest solutions

View more solutions

Latest comments

  • Avatarfreak•655
    @avatarfreakPosted over 3 years ago

    Hey, nice transition on the toggle button.

    • For toggling, I prefer using the radio button. It is easy to target with js.
    • I did the same kind of transition with a different approach. Have a look at my solution . Feedback would be welcomed. Happy coding.
    Marked as helpful
    0
  • Avatarfreak•655
    @avatarfreakPosted over 3 years ago

    Nice and congratulation on completing the challenge but here is some issue that needs to be rectified.

    • your site is not published. I'm guessing you may have entered the wrong path in the live URL field.
    • Correct path to your solution solution
    • In the readme file. You gave the wrong path. 404 pages are showing.
    • Image is missing.

    Happy coding. These are minor issues and can easily be fixed it.

    Marked as helpful
    0
  • Avatarfreak•655
    @avatarfreakPosted over 3 years ago

    It is really looking nice. One minor issue in mobile devices, there is a horizontal shift in layout, overflow kind of issue. Happy coding.

    1
  • Avatarfreak•655
    @avatarfreakPosted over 3 years ago
    • Good work, Design-wise it is good and responsive.
    • For the button try using pseudo-element.
      ::after or ::before.
    • In my opinion, it is easier to target elements. As it will always be relative to its immediate parent. something like this example.
    .image-container{
    position:relative;
}

.image-container::after{
    content:'';
    position:absolute;
    top:0;
    left:0;
    width:100%;
    height:100%
}
    Marked as helpful
    0
  • Avatarfreak•655
    @avatarfreakPosted over 3 years ago
    • Design is good and responsive.
    • I think your email validation is not working properly after entering the correct email. It still complains wrong email.
    1
  • Avatarfreak•655
    @avatarfreakPosted over 3 years ago

    Very well done from a design perspective.

    One thing I found a little unusual is transition duration. I meant to say there is a delay of few seconds during the transition.

    Secondly, you could have made a single component and target the attribute and replace image and quotation using javascript

    element.setAttribute('src', 'path/to/image/')
element.textContent= "quotation"

    For slide show logic you can check my link given below. It is simple javascript.

    slideshow

    0