Skip to content
OverviewSolutions
19
Comments
87
Harmanjot Singh
@arkharman12

All comments

  • Harmanjot Singh•985
    @arkharman12Posted over 2 years ago

    A few things I have noticed:

    • Looks like "Start my trial" button is missing a hover state?
    • Mobile layout is not matching with the given design. Especially the billing area.
    • There is no margin around content on 375px.

    Good luck!

    0
  • Harmanjot Singh•985
    @arkharman12Posted over 2 years ago

    You might have to use fetch("url", {cache: "no-cache"}) for quickly getting the new advice.

    Marked as helpful
    0
  • Shashree Samuel•9,260
    @shashreesamuelSubmitted over 2 years ago

    Feel free to leave any feedback on my solution, I don't have a certain part of the solution that need s feedback so always happy to improve and get better in this journey.

    Cheers Happy coding 👍

    FAQ Accordion Card with HTML, CSS and JS

    1
    Harmanjot Singh•985
    @arkharman12Posted over 2 years ago

    Add cursor to pointer over the whole accordion, you never know where the user is going to start opening! 😁

    0
  • Harmanjot Singh•985
    @arkharman12Posted over 2 years ago

    I would say sizing, spacing and positioning of the overall site could be improved to better match with the given design.

    Nice work overall and good luck!

    1
  • Kenneth Lauderbach•140
    @kennbachSubmitted over 2 years ago

    Hello Mentors,

    Thank you for taking the time to review my project. Please feel free to make any comments and suggestions. All feedback is welcome.

    Cheers!

    Bookmark Landing Page

    1
    Harmanjot Singh•985
    @arkharman12Posted over 2 years ago

    A few things I have noticed in your solution:

    • When the mobile menu is opened, it's not ideal to let the user scroll. Also, if the window width is increased while the menu is still open, half of the logo disappears.
    • Change the color of the input field. I cannot see what I am typing.

    Nice work overall and good luck!

    Marked as helpful
    0
  • Harmanjot Singh•985
    @arkharman12Posted over 2 years ago

    Success and error message is not properly placed on desktop screens. Otherwise, looks good!

    0
  • Harmanjot Singh•985
    @arkharman12Posted over 2 years ago
    • Use drop-shadow for the hover effect
    • Advice delivery rate is quite slow
    • Fixed width and height of the box is more appropriate for UX

    Good luck!

    1
  • Harmanjot Singh•985
    @arkharman12Posted over 2 years ago
    • Button is not centered in the box.
    • You might have to use fetch("url", {cache: "no-cache"}) for quickly getting the new advice.
    0
  • liezl•190
    @liezsmSubmitted over 2 years ago

    Hi all just finished this challenge any feedbacks tips suggesstions advices will do 🥰. I'm curious tho how can I achieve that glowing box shadow when button is hovered, I tried it myself but my btn is clip-path so it doesn't show when hovered but when i removed clip-path it works, any idea how to do it?

    Advice Generator App using HTML CSS SASS and API using async/await

    4
    Harmanjot Singh•985
    @arkharman12Posted over 2 years ago

    Make the container with fixed width and height because jumping around of text is not best for UX. The position of the button should also be fixed in one place. Good luck!

    Marked as helpful
    0
  • Mariem Bchir•140
    @MabchirSubmitted over 2 years ago

    It took a long time to set up this initial page which barely matched the given design. I have a feeling that I am approaching this in a very non-strategic way :

    • I determine the big elements and the smaller ones then I start building...

    I would love to hear some really critical feedback on this non-responsive desktop version!

    Equalizer Landing page (non-responsive Desktop version)

    4
    Harmanjot Singh•985
    @arkharman12Posted over 2 years ago

    Try to make the page responsive.

    0
  • Harmanjot Singh•985
    @arkharman12Posted over 2 years ago

    Your button requires two clicks to get to the next advice.

    Marked as helpful
    0
  • Karishma Garg•1,010
    @karishma-devSubmitted almost 3 years ago

    Hey Guys, I just finished the Rock, Paper, Scissors Game Challenge. I would like you all to see it and let me know how I can improve it. Let me know my mistakes. Thank you!.

    Rock, Paper, Scissors Game

    2
    Harmanjot Singh•985
    @arkharman12Posted almost 3 years ago
    • Scoreboard should not go in negative. Keep it at 0 if the player loses in the first game.
    • Bottom half of the viewport is cut out at 1440px.
    Marked as helpful
    0