Skip to content
OverviewSolutions
6
Comments
6
Gita Ventyana
@appsbygita

All comments

  • Gita Ventyana•100
    @appsbygitaPosted 5 months ago

    Nice! Well-structured, readable code and responsive design.

    0
  • Gita Ventyana•100
    @appsbygitaPosted 5 months ago

    Looks like there's something wrong with the font setup. I think it's better to use @import to import fonts from Google.

    0
  • Alim Asiidik•80
    @alimassidik210Submitted 5 months ago
    What are you most proud of, and what would you do differently next time?

    I am proud to be able to use pseudo-classes and media queries in CSS, next time ? i don't know

    What challenges did you encounter, and how did you overcome them?

    I was challenged with designing for the mobile version. To address this, I focused on creating the HTML structure first, then styled the CSS for mobile devices before moving on to the desktop version.

    1 used CSS pseudo-elements and media query

    2
    Gita Ventyana•100
    @appsbygitaPosted 5 months ago

    Nice job! Just a small thing missed: the last row of the nutrition table shouldn't have a bottom border. A good chance to practice using :not(:last-child) selector.

    0
  • Ali Ayad•60
    @ali-ayadSubmitted 5 months ago
    What are you most proud of, and what would you do differently next time?

    what i am proud in, is how to deal with flex

    What challenges did you encounter, and how did you overcome them?

    how to center divs

    What specific areas of your project would you like help with?

    i want to make the code less

    html css

    3
    Gita Ventyana•100
    @appsbygitaPosted 5 months ago

    Overall, it looks good. There's just a small discrepancy with the design. The space between name and location should be smaller than the space between location and the line after it.

    1
  • Gita Ventyana•100
    @appsbygitaPosted 5 months ago

    Need a little work for the responsive card width. On a <327px screen size, the card is wider than the display. It would be better to set a left and right padding for the mobile screen and let the card width take up the space left.

    Marked as helpful
    0
  • Gita Ventyana•100
    @appsbygitaPosted 5 months ago

    Overall, the solution matches the design, and the code is clear and readable. I just have a couple of feedbacks to consider:

    • There is no semantic HTML included. This is something that I often forget myself, especially when making a short page like this.
    • Spacing in the code is not formatted. For a short code like this, it might not be a problem and I can still read it clearly. But when the code starts to get longer, it will quickly become a problem.
    Marked as helpful
    0