Skip to content
OverviewSolutions
36
Comments
9
P
Anna Dominguez
@anna-dominguez

All comments

  • P
    Anna Dominguez•710
    @anna-dominguezPosted about 2 months ago

    Good job ! You can lower the text size to get a more closer solution.

    0
  • P
    Anna Dominguez•710
    @anna-dominguezPosted about 2 months ago

    Really good solution ! You just forgot the cart svg on the button

    0
  • P
    Anna Dominguez•710
    @anna-dominguezPosted about 2 months ago

    Hi ! Good job doing components for your solution 😃 In your layout you could declare your two fonts and use them differently with Tailwind you can find documentation here. You're almost there for the colors.

    0
  • P
    Anna Dominguez•710
    @anna-dominguezPosted about 2 months ago

    Good job on creating components for your CardLink! You could include the

    <li>...</li>

    directly inside it, so you don't have to write it each time.

    Also, in your CardLink, you have a target prop assigned to _self. I assume this is for links you don't have yet, but you're not actually using the target prop in Link, so it's automatically set to _blank. If you want to have a more closely look at the designs, you could change the title size.

    Good work :D

    0
  • Jenelle Holloway•30
    @hollowayjenelleSubmitted about 2 months ago
    What are you most proud of, and what would you do differently next time?

    I'm getting better with my CSS.

    What challenges did you encounter, and how did you overcome them?

    I forgotten some stuff about CSS like object-fit and box-sizing but I managed to solve it with the help of MDN

    What specific areas of your project would you like help with?

    N/A

    Blog Review Card using React

    #react
    1
    P
    Anna Dominguez•710
    @anna-dominguezPosted about 2 months ago

    Good job! Your project closely matches the design. You could add a

    cursor: pointer;

    to the blogTitle in the CSS. Since it's a blog card, this would indicate to users that it's clickable.

    1
  • P
    Anna Dominguez•710
    @anna-dominguezPosted about 2 months ago

    Impressive, no visible difference. Nothing to say with your code, all good. Good job !

    0
  • P
    Anna Dominguez•710
    @anna-dominguezPosted almost 2 years ago

    Hi ! This is a good first project with HTML/CSS only 😊

    Some differences that jump out at me from the two reference images:

    • You must have forgotten to use the font given in the guide, as in the case of font colours
    • I'm sure you could improve the margin and padding for the title and description

    Have a good day!

    0
  • P
    Anna Dominguez•710
    @anna-dominguezPosted almost 2 years ago

    Hey ! I had never seen the picture tag used before, it helps a lot for media queries. Good job with only HTML and CSS 🙌🏻

    Things you could improve:

    • Hover over the add to cart button
    • You should check out the align... to center your button content vertically
    • Try to delete the spaces for your <h5>Perfume</h5> and style it out with CSS with letter-spacing

    Let me know if you have any doubt 🚀

    1
  • P
    Anna Dominguez•710
    @anna-dominguezPosted almost 2 years ago

    Good job! And a good idea for the copy button, it's a plus 🙌🏻 I've seen your GitHub repository for this challenge, you have done all the logic with the base of the project in HTML, why don't you try challenging yourself with frameworks? I've seen a lot of cases and I'm sure you could find a way with states in order to change your classes

    Marked as helpful
    1