QR code component using HTML CSS

Community feedback

• 

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  Some recommendations regarding your code that could be of interest to you.

  In order to fix the accessibility issues:

  • I couldn't view your Github repository, even so I'll try to give suggestion about some accessibility issues.
  • You need to replace <div class="attribution"> with the <footer class="attribution"> tag. You'd better use Semantic HTML, and you can also reach more information about it from Using Semantic HTML Tags Correctly.
  • Each main content needs to start with an h1 element. Your accessibility report states page should contain a level-one heading. So, you should use one <h1> element in the <main> tag. You can replace your <p class="title">Improve your front-end skills by building projects</p> element with the <h1 class="title">Improve your front-end skills by building projects</h1> element.

  After committing the changes on GitHub and you need to deploy it as a live site. Finally, you should click generate a new report on this solution page to clear the warnings.

  Hope I am helpful. :)

  Marked as helpful

  1
• 

  P

  Anna Dominguez•680

  @anna-dominguezPosted over 1 year ago

  Hi ! This is a good first project with HTML/CSS only 😊

  Some differences that jump out at me from the two reference images:

  • You must have forgotten to use the font given in the guide, as in the case of font colours
  • I'm sure you could improve the margin and padding for the title and description

  Have a good day!

  0