Latest solutions
Base Apparel Coming Soon with Web Animations API
#animation#sass/scssPSubmitted 8 months agoIf you can spare a minute, please let me know what you think about the validation part of the challenge. What do you think about the regex pattern? How should one deal with the tooltips displayed by browser?
GitHub User Search with React
#axios#react#sass/scssPSubmitted 9 months agoAny suggestions about:
- fixing the item clicking issue
- dealing with rate limits
are welcome. I'll be grateful for any other feedback as well.
Loopstudios landing page with SCSS & Vite
#sass/scss#vite#animationPSubmitted about 1 year agoIs this a well-written piece of code? I'm happy to have completed it, but I'm unsure about the quality of my projects. I'd appreciate if anybody could share some insight
Latest comments
- @Candido-HMSubmitted about 2 years agoP@ania221BPosted about 2 years ago
Hello Candido 👋
Congratulation on completing the challenge! It looks really nice 🙂
I've noticed that you often set
height
on elements. It's a good idea to leave that out and instead let theheight
be decided by the contents of the element and things like padding. So to make an element take up more vertical space, you could give it biggerpadding
, addmargin
to elements inside, increaseline-height
of the text and so on. I hope this helps.I apologize for commenting in English, but I don't know Spanish.
Happy coding 🙂
Marked as helpful1 - @modieeeSubmitted over 2 years agoP@ania221BPosted over 2 years ago
Hello Modade!
To answer your question: yes, you can place the cards with CSS Grid. One way to do so would be defining rows and columns for the cards:
.grid_card_one { grid-row: 3 / span 2; grid-column: 1; } .grid_card_two { grid-row: 2 / span 2; grid-column: 2; } .grid_card_three { grid-row: 4 / span 2; grid-column: 2; } .grid_card_four { grid-row: 3 / span 2; grid-column: 3; }
Here's a CSS Grid cheatsheet
I hope this helps 😊
0 - @GreatNation111Submitted over 2 years agoP@ania221BPosted over 2 years ago
Hello @GreatNation111👋
You've mentioned that the spacing between the paragraph and header is bigger than you wanted. This might be due to
line-height
set on<h1>
. I think currently it is the same as for the rest of text content. It is worth decreasing it, as smallerline-height
makes big text look better. Try changing it to 1.2 or similar value and see if it helps. Happy coding 😊Marked as helpful0