Skip to content
OverviewSolutions
3
Comments
2
Anastasiia
@anastasiiaal

All comments

  • FrontendBy-GJ•430
    @FrontendBy-GJSubmitted over 1 year ago

    This challenge was a pain in the butt. I had trouble displaying some of the data, like the countries currency. Besides that, this was a fun and challenging project.

    I would love some feedback, thanks!

    REST Countries API with color theme switcher

    1
    Anastasiia•120
    @anastasiiaalPosted over 1 year ago

    Hello there 👋

    Love your solution result, good job!

    I have a tiny suggestion to make to improve your site. Now, when on a country-designated page, it has an y-axis scroll. Probably it comes from section's first child's height of 100vh. To fix that, I'd do the following:

    • remove min-height from this element
    • remove bgc from section
    • set your root's min-height to 100vh
    • set your root's bgc to the color of background

    Hope it helps 🙂

    Marked as helpful
    0
  • Hesam•420
    @hesam-fattahiSubmitted over 1 year ago

    Some things that are added or changed in this solution:

    • 🎨 A little redesign (transparent header, cards redesign and a lot of border-radius)

    • 👥 sort by population.

    • 🖥️ skeleton screen while loading

    This was the biggest challenge of Frontend mentor that I've worked on so far. The project is still in progress cause the js code I think needs a lot of refactoring.

    So any feedback on how I can improve the code is greatly appreciated. 🖤

    Thank you :)

    Where in the world (SASS - JS - REST Countries API)

    2
    Anastasiia•120
    @anastasiiaalPosted over 1 year ago

    Hello there! 👋 I love how you redesigned the initial project, especially your feature with a tiny flag near the border country, really well done!! 🔥 On the other hand, there seems to be some issue with the countries that do not have neighbours: check out Barbados, e.g. You should probably add some condition before your render. Otherwise, great job!

    Marked as helpful
    0