Skip to content
Submitted over 1 year ago

REST Countries API with color theme switcher

FrontendBy-GJ•430
@FrontendBy-GJ
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...REST Countries API with color theme switcher
  • HTML
  • CSS
  • JS
  • API
4advanced

Design comparison

SolutionDesign

Solution retrospective

This challenge was a pain in the butt. I had trouble displaying some of the data, like the countries currency. Besides that, this was a fun and challenging project.

I would love some feedback, thanks!

Community feedback

  • Anastasiia•120
    @anastasiiaalPosted over 1 year ago

    Hello there 👋

    Love your solution result, good job!

    I have a tiny suggestion to make to improve your site. Now, when on a country-designated page, it has an y-axis scroll. Probably it comes from section's first child's height of 100vh. To fix that, I'd do the following:

    • remove min-height from this element
    • remove bgc from section
    • set your root's min-height to 100vh
    • set your root's bgc to the color of background

    Hope it helps 🙂

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord