Paul Lockyer
@alittlebrokenAll comments
- @mylonakos14Submitted about 2 months ago@alittlebrokenPosted about 2 months ago
Very good, looks very professional.
The only thing I would add is in the stylesheet add something like the below to cover the whole of the page to avoid the white space at the bottom of the page
body { height: 100vh; }
0 - @YorDNSubmitted 3 months ago@alittlebrokenPosted 2 months ago
I have noticed that when in mobile view of 375px width that the page looks squished together.
Perhaps set a width on the container of around 350px and remove the positioning on the container class.
Aside from that good job, looks really great.
0 - @naveenkkannanSubmitted 2 months agoWhat are you most proud of, and what would you do differently next time?
I am proud to note that I nearly achieved the desired spacing between elements. In future projects, I will explore alternative methods for spacing to enhance the layout further.
What specific areas of your project would you like help with?I am seeking assistance with achieving precise spacing between elements. I am having difficulty extracting accurate information regarding element spacing and would like to verify whether I have achieved the desired spacing correctly. Guidance on this matter would be greatly appreciated.
@alittlebrokenPosted 2 months agoGood job, looks very nice and clean.
I would suggest perhaps moving the CSS into it's own file for ease of reading the index file.
I would also wrap the card in a landmark component like main to aid accessibility.
Aside from that love it.
1 - @Abby-LiuSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
To make a beautiful page. It's my first try.
What challenges did you encounter, and how did you overcome them?there are too many difficulties I've met... thanks to search engine
@alittlebrokenPosted 3 months agoVery good job, matches up very nicely.
I would replace your <div class="card"> ... </div> with a semantic tag like <main class="card"> ... </main> to pass the landmark tests and help screen readers process the page.
Marked as helpful1