Use native html and css

Community feedback

• 

  Paul Lockyer•60

  @alittlebrokenPosted 2 months ago

  Very good job, matches up very nicely.

  I would replace your <div class="card"> ... </div> with a semantic tag like <main class="card"> ... </main> to pass the landmark tests and help screen readers process the page.

  Marked as helpful

  1
• 

  P

  Teodor Jenkler•3,740

  @TedJenklerPosted 2 months ago

  Hi @Abby-Liu,

  Nice project! To improve it, here are a few suggestions:

  I would recommend using the <main> tag to make the structure more semantic, which will also improve SEO and accessibility (like the first feedback mentioned*)

  While you should have a maximum of one h1, it’s important to use h2, h3, and so on in descending order of importance. Since h1 is typically used for the page header, in this case, the first heading should actually be an h2.

  Because of the shareability of this project, you should add meta OG (Open Graph) tags to create beautiful link previews and improve SEO.

  Consider making the QR codes clickable, which can help older people by allowing them to use it as a link instead of scanning it.

  As an extra challenge, I would suggest learning how to create custom QR codes—it’s a really fun topic!

  Keep up the good work!

  Best, Teodor

  0
• 

  Abby•60

  @Abby-LiuPosted 2 months ago

  Thank you so much. I'm going to modify it!

  0