Ahmad Alqaisi

Latest comments

• 

  Shashank Yadav•40

  @yshashankySubmitted over 2 years ago

  

  Responsive page using Flexbox and CSS for advice generator app

  1

  40
  

  Ahmad Alqaisi•940

  @alQaisiPosted over 2 years ago

  Hi Shashank :)

  Great job!

  I think you should add a catch after you call the promise from the userAction function, or you could add a try-catch block in the userAction function body.

  The idea is to know when there is an error, it could be a connection error or any other issue, so you can know what is the issue and maybe try to fix them.

  Have a nice day.

  Marked as helpful

  0
• 

  Kate•170

  @YayoKBSubmitted over 2 years ago

  

  Responsive landing page with CSS grid and JavaScript

  1

  30
  

  Ahmad Alqaisi•940

  @alQaisiPosted over 2 years ago

  Hi Kate :)

  Great job!

  To solve your problem, you must store the email value once the user clicks on the button, in your solution you store it when the website loads so it would be an empty string.

  try to create a variable that holds the email value in the function that handles the submission of the form.

  0
• 

  Alvaro Ormeno•150

  @alvaroormenoSubmitted over 2 years ago

  

  Article Preview Component

  1

  60
  

  Ahmad Alqaisi•940

  @alQaisiPosted over 2 years ago

  Hi Alvaro.

  You did a great job!

  to fix HTML & Accessibility issue wrap your component with main tag or add a role attribute with a value of main.

  Have a nice day.

  0
• 

  Andesa•110

  @AndesaputraSubmitted over 2 years ago

  

  Order Summary Component

  1

  50
  

  Ahmad Alqaisi•940

  @alQaisiPosted over 2 years ago

  Hi Andesa :)

  Great work.

  Try to read more about the background image on the MDN website that will help you to make your solution looks more like the original design.

  The role attribute can't have a value like "footer" or "section" you can use semantic tag instead of divs or just use a value that is acceptable by the role attribute.

  Marked as helpful

  2
• 

  Shard Codes•430

  @Shard-CodesSubmitted over 2 years ago

  

  Stats preview card component made with Html, and Css

  #accessibility#bem

  1

  30
  

  Ahmad Alqaisi•940

  @alQaisiPosted over 2 years ago

  Hi there :)

  You did a great job!

  Try to read about background blend mode to make the overlay color in your solution look like the original design.

  Also, try to add more padding to the text container.

  Have a nice day.

  Marked as helpful

  1
• 

  Suatcan•50

  @suatcgSubmitted over 2 years ago

  

  Sunny Side Agency

  #bem#sass/scss

  1

  10
  

  Ahmad Alqaisi•940

  @alQaisiPosted over 2 years ago

  Hi Suatcan :)

  If you want to make it better try to add an aria-label for repetitive semantic elements to make the browser distinguish them, in your solution you have used more than one nav element.

  It's not a good practice to put a div inside a button, if you want the div to be clickable just add an event listener to it but it should not be inside a button.

  Don't forget to add a heading into any section to fix HTML & Accessibility issues.

  By the way, you did a great job!

  Marked as helpful

  0