Skip to content
OverviewSolutions
38
Comments
20
Ahmad Alqaisi
@alQaisi

All comments

  • Ahmad Alqaisi•940
    @alQaisiPosted over 2 years ago

    Hi Shashank :)

    Great job!

    I think you should add a catch after you call the promise from the userAction function, or you could add a try-catch block in the userAction function body.

    The idea is to know when there is an error, it could be a connection error or any other issue, so you can know what is the issue and maybe try to fix them.

    Have a nice day.

    Marked as helpful
    0
  • Ahmad Alqaisi•940
    @alQaisiPosted over 2 years ago

    Hi Kate :)

    Great job!

    To solve your problem, you must store the email value once the user clicks on the button, in your solution you store it when the website loads so it would be an empty string.

    try to create a variable that holds the email value in the function that handles the submission of the form.

    0
  • Ahmad Alqaisi•940
    @alQaisiPosted over 2 years ago

    Hi Alvaro.

    You did a great job!

    to fix HTML & Accessibility issue wrap your component with main tag or add a role attribute with a value of main.

    Have a nice day.

    0
  • Ahmad Alqaisi•940
    @alQaisiPosted over 2 years ago

    Hi Andesa :)

    Great work.

    Try to read more about the background image on the MDN website that will help you to make your solution looks more like the original design.

    The role attribute can't have a value like "footer" or "section" you can use semantic tag instead of divs or just use a value that is acceptable by the role attribute.

    Marked as helpful
    2
  • Ahmad Alqaisi•940
    @alQaisiPosted over 2 years ago

    Hi there :)

    You did a great job!

    Try to read about background blend mode to make the overlay color in your solution look like the original design.

    Also, try to add more padding to the text container.

    Have a nice day.

    Marked as helpful
    1
  • Suatcan•50
    @suatcgSubmitted over 2 years ago

    Please let me know If you find any issues I would be appreciated it. Meanwhile, I've been coping with the last image section, I could not fit to screen 100% width, If you have a solution for it please let me know.

    Sunny Side Agency

    1
    Ahmad Alqaisi•940
    @alQaisiPosted over 2 years ago

    Hi Suatcan :)

    If you want to make it better try to add an aria-label for repetitive semantic elements to make the browser distinguish them, in your solution you have used more than one nav element.

    It's not a good practice to put a div inside a button, if you want the div to be clickable just add an event listener to it but it should not be inside a button.

    Don't forget to add a heading into any section to fix HTML & Accessibility issues.

    By the way, you did a great job!

    Marked as helpful
    0
  • Eji Cyril Arinze•220
    @Cyril-ArinzeSubmitted over 2 years ago

    This was a great challenge, I am glad I was able to complete it. i start learning javascript 2months ago and I am happy that i am making progress. However, i tried storing the user todo list to their web browsers but i couldn't achieve that. i am open to suggestions on how i can do that. thank you

    Css flex, sematic html, logic and javascript

    1
    Ahmad Alqaisi•940
    @alQaisiPosted over 2 years ago

    Hi, your work is impressive!

    to store data in the browser you need to use something called local storage which takes 2 arguments, the first one is the name or the key for the value you want to store and the second one is the data itself.

    Local storage takes only string data so you have to convert your JSON or objects to string using stringify method and then parse it into an object when you want to fetch it.

    read more about local storage on the MDN website.

    Have a nice day :)

    Marked as helpful
    1
  • Ahmad Alqaisi•940
    @alQaisiPosted over 2 years ago

    Hi John, React component re-render whenever the state changes, so you can make a function that handles the request and changes the state with the new data, you should pass that function as a call back to the button. You can keep your work, but it is not the right implementation for this project.

    Great work by the way.

    0
  • Ahmad Alqaisi•940
    @alQaisiPosted over 2 years ago

    Hi Veljko :)

    I think it is labeled as advanced because it's a multi-page application that requires a strong background in javascript, the layout for this project is very easy but the hard part is to handle the API request for countries and borders countries alongside making specific routes for each country.

    by the way, don't forget to add the alt attribute into each flag to get rid of HTML & Accessibility issues. Great Job!

    Marked as helpful
    1
  • Atharv Pote•325
    @atharvpoteSubmitted over 2 years ago

    This was a fun project. I hope you guys like my solution. If you have suggestion please tell me I'd love to hear them.

    Calculator App

    1
    Ahmad Alqaisi•940
    @alQaisiPosted over 2 years ago

    Hi Atharv :) you did such a nice thing! To fix accessibility issues just wrap your element into main tag. If you want to improve your solution just try to add an element that contains the previous number with the current math operation so the user knows the numbers and the operation. Last thing try to make buttons smaller so they get closer to the original design. Have a nice day.

    Marked as helpful
    1
  • Ahmad Alqaisi•940
    @alQaisiPosted over 2 years ago

    Hi Samuel :) you did a great job! I suggest adding an alt attribute to each image in the project to fix all of the HTML & accessibility issues. And don't forget to wrap your whole container into main tag or you could use the role attribute, but the best thing is to use semantic HTML tags such as main, header, and footer.

    Marked as helpful
    0
  • Rafael•90
    @henriquerocharafaelSubmitted over 2 years ago

    I would like a help to implement a code for checking if the user did hit a note before submitting the answer. Thanks!

    Used HTML, CSS and Javascript

    1
    Ahmad Alqaisi•940
    @alQaisiPosted over 2 years ago

    hi Rafael :) Great Job. I suggest wrapping your component with a main tag to fix accessibility issues. to check if the user did hit a note you can define a variable and give it an initial value of false, and whenever the user clicks a note you must change the value of that variable to true, and you should not allow the user to submit without clicking on a note.

    Marked as helpful
    0