@EdoardoRamondetti
Abigail Figaro
@abigailjulieAll comments
- @abigailjulie
None of the active states are included and I can't see your code. See if you can add the color overlay on the image. The was the most challenging thing about this exercise.
- @AeroBW@abigailjulie
Very nice only you forgot about the model that is supposed to show up when the user click the profile picture. active-states-basket-filled, active-states-basket-empty are missing. Great Work!
- @temesgen-982@abigailjulie
None of the styling is correct, font, color, margin, padding. Being able to recreate the design file as closely as possible is important. Give it an hour, I know you can do it!
- @hkaur108What specific areas of your project would you like help with?
I am facing issues with removing the default styles of the input field, I have tried -webkit-appearance:none, but that does not seem to help. Please advise as to how I can fix it.
Secondly, I have tried to add accessibility into the form for the first time, please let me know if it is correct and something else can be done to improve the solution.
Any other sort of feedback is also welcomed.
@abigailjulieIt's clear you have a lot of experience using react but I fear it's over complicating this exercise. The preview doesn't even show up. I think it's worth while trying to replicate the design file exactly. The margins and paddings are inconsistent. I think added a min-width would stop the form from stretching every time a cursor hovers over the input. Capitalization and margins on the error messages are inconsistent. You are clearly capable, just pay more attention to details. Looks Great!
Marked as helpful - @Chris-WaggWhat specific areas of your project would you like help with?
Accessibility is my main focus so any feedback on that would be appreciated
@abigailjulieI was able to tab an select all of the tabs using my keyboard which is great! The image isn't properly place, It's shifted to the right when I open the website. I would also make the white space larger so that it's only growing in one direction when the text is revealed. Looks great!
- P@YuliaLantzberg@abigailjulie
There's an issue with font-family. It's visible when I use your website, not on the preview here on Frontend Mentor. I'm not sure how you applied the transparent backlit effect but it looks great!
Marked as helpful - @dinixtusWhat are you most proud of, and what would you do differently next time?
I am proud of my procent buttons and a input. I learned more about 'this'.
What challenges did you encounter, and how did you overcome them?Buttons and input were difficult(select those and use procent). I did it with 'this', and 'if' for checking what user selected.
What specific areas of your project would you like help with?I would like to have counsellings about how I can write my code better more optimistic.
@abigailjuliePadding isn't correct on mobile. Reset and custom button don't have the correct styling initially. Great job with the custom functionality! I wasn't able to get it. Hopefully someone who can help responds to your question! Keep going!
- @dinixtusWhat are you most proud of, and what would you do differently next time?
It is my first time when I work with data and use fetch. I unersrood everything and made this project quickly.
What specific areas of your project would you like help with?Maybe JS-file could be simpler and shorter but I don't know how I can do it.
@abigailjulielooks great! I didn't see much bootstrap though?
- @chimeziedanielWhat are you most proud of, and what would you do differently next time?
write better and shorter code and think better next time
@abigailjulieIn addition to bootstrap you needed some more css code. Background color, flexbox, google fonts, and more are all missing from your code. Take a look at other people's solutions when you get lost, keep going!
- @TusharJetagi@abigailjulie
When I preview you're site the share button is completely missing. I'm not sure why it shows up in the preview but not the website.
- @Raymond023What are you most proud of, and what would you do differently next time?
firs time using CSS grid
What specific areas of your project would you like help with?improvement with accessibility
@abigailjulieLine-spacing, margins and font colors are a little off. Most of these projects are centered on the page. Getting close!
- @BistuBastian@abigailjulie
Font size and weight probably need adjusting. Looks good!
- P@nikolasladic@abigailjulie
Looks great, I think the spacing and the sizing of the words are not perfect but you are so close I don't have any notes! great job
- @chilldeleuzeWhat are you most proud of, and what would you do differently next time?
I'm getting the hang of using variables and I also used a few more complex selectors (sibling selector).
What challenges did you encounter, and how did you overcome them?This was more challenging than the previous ones. I had some trouble styling the list-markers, especially for the numbered list.
@abigailjulieThe font-weight is more nuanced than what's shown. Break lines should appear more consistent. Line spacing of text looks off. Adjust the spacing of the bullets in the ul li. Looks great!
- @ROJOmaxWhat are you most proud of, and what would you do differently next time?
I'm most proud of learning transition properties in CSS, mastering the target attribute in HTML, and effectively using lists in HTML. These skills have greatly enhanced my web development capabilities.
Next time, I would focus more on doing it faster.
What challenges did you encounter, and how did you overcome them?One of the significant challenges I faced was customizing the links list in my web projects. Initially, getting the right styling and functionality for each link in the list was quite tricky.
What specific areas of your project would you like help with?none.
@abigailjulieShould be centered on the page. looks great!
- @dharmen06@abigailjulie
I'm assuming you submitted this too early. Try to work on your code a bit more even though it's been submitted.
- @ducmanhaha@abigailjulie
Seems like the text isn't the correct size or spaced correctly from the other elements. Even though this is a small project I've seen people break of the css in a different file. Might help readability? Having class names like "content" and "content1" is not clear enough. You have part of the code commented out, if not needed delete.
