i will be very glad to hear your guys feedback about this project thx for the support everyone 😊😇
Aastha Anand
@aasthaanand123All comments
- @Mohammd1321Submitted over 3 years ago@aasthaanand123Posted over 3 years ago
Hey! Good work but in the switching between monthly and yearly, the value does not change to "/year" so u might wanna check that once. Happy coding!
1 - @YuniacSubmitted over 3 years ago
I think the layout if I started via mobile-first would have saved me time and frustration, but it's a learning process so it's alright. I also think the javascript could have been better but I learned a few things while doing it like this, the not so straight-ahead way so I think it was alright too.
Feedback is always welcome.
@aasthaanand123Posted over 3 years agoHey, good work! But when toggled to yearly billing the price does not switch to "/year", so you might want to check that out. Happy coding!
1 - @eddieloasterSubmitted over 3 years ago
this is my first work ever ...any feedback/criticism will be helpful please and thank you
@aasthaanand123Posted over 3 years agoI did this challenge too and I'll recommend you read upon what is flexbox and how it is used (and also media queries for the responsiveness of the page). What you used(position:relative) is not the correct methodology to do this challenge because that won't work on different screen sizes and that simply can be done with the organized approach of flexbox or grid. Happy coding!
0 - @IkwemogenaSubmitted over 3 years ago
Hi,
I would like your feedback on this code.
Thank you. :-)
@aasthaanand123Posted over 3 years agoHey, I did the same challenge and observed certain things so you can do the following for some of it: give the container a min-height of 100vh and align items to the center. That way you won't have to give a margin top to the card. Another thing ,your code link does not directly point to the repository of the given project so you can update that. Also increase the font-size and change the color of the p in the top card. Happy coding!
0 - @MasterKrabSubmitted over 3 years ago
This is my first practice with React and I would appreciate any feedback.
I have added a 404 error page and a spinner.
@aasthaanand123Posted over 3 years agoHey! Great job. I wanted to ask if the same thing can be achieved using just html,css and Javascript?
1