REST Countries API | Styled Components, React Router & Localstorage

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hello there, MasterKrab! 👋

  Great job on this challenge! 👏 I really like the loading animation that you added and I noticed you styled the scroll bar! 👏 Overall, your solution looks pretty good! 👍 It's nice to see you try out a React, too! 😀

  There's a lot of space between the country cards when the layout changes from a four to three column grid. I suggest putting a fixed amount of space between the cards and centering them in their container so that they don't look so distanced from each other. 🙂

  Also, the filter option doesn't seem to be working so well for me. Currently, selecting a filter and searching for a country still shows a few countries in other regions unless I make my search quite specific (e.g., selecting "Africa" then typing "u" into the search bar shows Portugal). You might want to take another look at that! 😉

  As always—keep coding (and happy coding, too)! 😁

  1

  ---

  

  MasterKrab•940

  @MasterKrabPosted over 3 years ago

  @ApplePieGiraffe Very true what you say, I already fixed it.

  Thank you very much for the feedback you always give me.

  0
• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, MasterKrab! 👋

  Good effort on this challenge! Your solution responds well and looks good. I like that load animation. Kudos for taking time and adding ":focus" pseudo-class for accessibility. I don't know React so I don't help with that but small tip from me is to add listener for your input and look for 'input' event so it will be filtering countries everytime user type a letter.

  Good luck with that, have fun coding! 💪

  1

  ---

  

  MasterKrab•940

  @MasterKrabPosted over 3 years ago

  @tediko Thank you so much!

  0
• 

  Aastha Anand•345

  @aasthaanand123Posted over 3 years ago

  Hey! Great job. I wanted to ask if the same thing can be achieved using just html,css and Javascript?

  1

  ---

  

  MasterKrab•940

  @MasterKrabPosted over 3 years ago

  @aasthaanand123 Thanks and of course it can be achieved with just html, css and js.

  0