Franco Bernardi• 150
@francobernardii
Submitted
How can my code be more efficient?
Am I using Sass in the correct way?
I don't feel comfortable with the way that i wrote my JS code, how can I do it cleaner?
Byte
@YonutDev
All comments
- Byte• 260
@YonutDev
Posted
Hello! 👋
The card logo doesn't load. Modify
imgtag source location toassets/images/card-logo.svgfromlogo-containerdiv.You use SCSS quite well excepting for some things.
Personally, I understand the code written by you in JavaScript without more code comments, but I still recommend jQuery, a awesome tool. Try to work as efficiently and simply as possible. By separating everything and adding comments, you can be as well organized as possible.
Marked as helpful
2 - Felipe Alencar Giacomini• 40
@felipe-alencar6
Submitted
Byte• 260@YonutDev
Posted
Hi there! 👋
In my opinion, you can add some hover animations on rating buttons, try to get as close as possible to the design. One more thing, you can select multiple rating buttons. You can do something so that the user can select only one rating button and only if he selected one can press Submit.
You could also look a little at the code to improve it & solve some of reported HTML Issues.
Good luck!
Marked as helpful
1 - Petru Banceanu• 110
@Petru14
Submitted
The most difficult part about this project was the hover state, because a didn't used in the past week's and I lost a while till I figure out the solutions. Any kind of feedback is more then welcome.
Byte• 260@YonutDev
Posted
Hi there! 👋
Congratulations! Everything you've done is almost done.
In my opinion, what should be changed is the color of the border to a darker one, and still you could add some transitions to make it look a little more good.
Marked as helpful
1 - Reyhan Dilek• 200
@Reyhandilek07
Submitted
Ä°t was so easy and enjoyable. Thanks a lot!
Byte• 260@YonutDev
Posted
Hi there! 👋
Congratulations! Everything you've done is almost done.
I recommend that you leave some space between the social media links and the end of the page for screens that are not very big. You can use some
<br>tags aftersocial-mediasdiv or usingpadding-bottomin the CSS ofsocial-mediasdiv. Besides this, you could also make the color of the button change faster, reducing the transition period, you could also add that when you hover over one of the social medias, its color changes, as in the design.Otherwise, everything seems fine.
Marked as helpful
0
