Responsive layout using HTML, CSS.

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hello Petru Banceanu,

  Congratulation on completing this challenge. Excellent work! I have few suggestions regarding your solution, if you don't mind:

  HTML

  1. Page should contain a level-one heading. In this challenge , as it’s not a whole page, and you can use <h1> with class sr-only aiming at visually hiding the element while keeping it accessible to assistive technologies

  2. The most important part in this challenge interactive elements. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..) for this imagine what would happen when you click on the image, there are two possible ways:
     1: If clicking the image would show a popup where the user can see the full NFT, here you use <button>. 2:If clicking the image would navigate the user to another page to see the NFT, here you can use <a>. For the same reason , you can use <a> to wrap Equilibrium #3429.

  3. The link wrapping the equilibrium image should either have Sr-only text, an aria-label or alt text that says where that link takes you.

  4. look up a bit more about how and when to write alt text on images. Learn the differences with decorative/meaningless images vs important content

  5. For any decorative images, each img tag should have empty alt="" and add aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in (icon-view, icon-ethereum, icon-clock ).

  6. To use more semantic tags , you may use <figure> and <figcaption> for the avatar's part.

  7. The alternate text of the avatar image should not be avatar, it’s meaningless. You can use the creator's name Jules Wyvern. Read more how to write an alt text

  8. For middle part of the card class="price__details d-flex", you can use an unordered list <ul>, in each <li> there should be <img> and <p> that way you can align them centrally.

  There are so many ways to do the hover effect on the image, The one I would use is pseudo elements::before, ::after. You can use pseudo-elements to change the teal background color to hsla. Then the opacity can be changed from 0 to 1 on the pseudo element on the hover. Also using pseudo elements makes your HTML more cleaner as there's no need for extra clutter in the HTML. The icon view does not really need to be in the HTML, yo may use CSS for it.

  • It's recommended to include a git ignore. This came with your starter files. It's less important in this challenge but will become extremely important as you move onto larger projects with build steps.

  Overall, Your code is clean and well-structured. Hopefully this feedback helps.

  Marked as helpful

  1

  ---

  

  Petru Banceanu•110

  @Petru14Posted about 2 years ago

  @PhoenixDev22 I really appreciate your feedback, it's very helpful and elaborated. Thank you so much!

  1

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  @Petru14 Glad it was helpful. Happy coding!

  0
• 

  Byte•260

  @YonutDevPosted about 2 years ago

  Hi there! 👋

  Congratulations! Everything you've done is almost done.

  In my opinion, what should be changed is the color of the border to a darker one, and still you could add some transitions to make it look a little more good.

  Read more about transitions

  Marked as helpful

  1