Skip to content
Submitted about 2 years ago

Responsive credit card challenge. Use of HTML, CSS, JS and SASS

Franco Bernardi•150
@francobernardii
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Interactive card details form
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

How can my code be more efficient?

Am I using Sass in the correct way?

I don't feel comfortable with the way that i wrote my JS code, how can I do it cleaner?

Community feedback

  • Byte•260
    @YonutDevPosted about 2 years ago

    Hello! 👋

    The card logo doesn't load. Modify img tag source location to assets/images/card-logo.svg from logo-container div.

    You use SCSS quite well excepting for some things.

    Personally, I understand the code written by you in JavaScript without more code comments, but I still recommend jQuery, a awesome tool. Try to work as efficiently and simply as possible. By separating everything and adding comments, you can be as well organized as possible.

    Look at this and practice it!

    Marked as helpful
    2
    Franco Bernardi•150
    @francobernardiiPosted about 2 years ago

    @YonutDev Thanks for your feedback! I'll take it in consideration for my future projects :)

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord