Skip to content
OverviewSolutions
5
Comments
6

Yevgeny

@YevgeniyMakkaveevMoscow210 points

I’m a mysterious individual who has yet to fill out my bio. One thing’s for certain: I love writing front-end code!

Latest solutions

Latest comments

  • Yevgeny•210
    @YevgeniyMakkaveevPosted over 3 years ago

    I don't know if it is a good idea or not, but i use one class just for the geometry, and make another style for the color. With it you can make just one file for the color that will apply to all app and you don't have to pass color props too all your components. It works for me in Sass, but i think it will work fine without it even on pure css. But I came here just to learn css tricks, so I am curious too about the right way. Also you may want to close the previous menu on a header when you open the other, but I guess it’s just me, who don’t like to open many things at the same time. The layout is readable even with all of the tabs open. And thanks for an example how style components and typescript work! Good luck and happy coding!

    0
  • Yevgeny•210
    @YevgeniyMakkaveevPosted over 3 years ago

    Hi! Great job. Only strange thing for me is const el instead of just editing class inner html. Other things, tat you may want to add is EventListener on a form, with prevent defalut option. so your input form will submit result on enter. It may be optional but I like to submit on enter. Good luck and happy coding!

    Marked as helpful
    1
  • Yevgeny•210
    @YevgeniyMakkaveevPosted over 3 years ago

    Display flexbox or display grid. With grid you can prevent pictures going where they want and stay in place. Grid structure for it imo will be cleaner, since you don't have to worry about flexbox shrink and grow. I do it with flexbox and it was a bit harder than i expect, but calculator with grid works predictable, and I wish i knew about it early. Hope it helps.

    Marked as helpful
    0
  • Yevgeny•210
    @YevgeniyMakkaveevPosted over 3 years ago

    Thx! Glad that it helps.

    0
  • Yevgeny•210
    @YevgeniyMakkaveevPosted over 3 years ago

    Thx for the feedback! Kinda funny that i check only for the zeroes but forget about numbers below zero.

    0
  • Yevgeny•210
    @YevgeniyMakkaveevPosted over 3 years ago

    Very good looking site! But it is a good practise to check values before calculating the results, with your solution you may get Infinity or a NaN. For this app it may be not a big deal, but when you start working with the api checking data on input will be a good practise, since unexpected null in render function may crash your website. Hope it helps Good luck and happy coding!

    0