Design comparison
Solution retrospective
Well thats first time i try to do the responsive design. Don't know if the solutions there are optimal, so be glad to hear how it should be done.
Community feedback
- @dannebrobPosted over 3 years ago
Hi, nice looking solution!
I noticed that if I view your page on smaller screens than 400px the layout don't work. What I tend to do myself is write the css to work on either mobile or on desktop first. And then use the @media at-rule just for the specific changes needed. So in this case I might have writen the css for the mobile view first and then writen the changes needed to work on lager screens in a media queries. Maybe this link will help you? https://www.w3schools.com/css/css_rwd_mediaqueries.asp
I was also thinking that you repeted the same css alot on some places (like on .gallery-back-img1/ and main-text-row-img1/). You might find it more efficent to write like explained on stack overflow: https://stackoverflow.com/questions/15374830/stop-repetition-of-css-code
Other than that, I like it.
I hope my sugestions will be useful to you.
Keep up the good work! πͺ
See you on the coding trail π
Marked as helpful2@YevgeniyMakkaveevPosted over 3 years ago@dannebrob Thx mate! That is really usefull. Fix 320p res bug, it was quiet obvious, so shame on me for missing that, even it was my first time doing @media rule and forgetting about mobile first for it. And thanks for the stackoverflow link. I was really start thinking about it, and want to start looking at the solution. Good luck in learning and coding for you too!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord