ReactJs with Styled Components, Mobile First, Flex and Grid.
Design comparison
Solution retrospective
A lot of what I did is in my readme, but anyway I still want to ask somethings.
What do you think about the way I'm handling with the Theme? I think it's the start of a scalable theme managment. But... at the same time I'm not liking the way I organized the colors. Any tip?
I would like to ask for better ways to deal with the images of the sections bellow the header. I'm used position absolute in their case but I'm sure it's not the best way to deal with it.
I also had some difficult in the blue section. Cause inside it we have an image in background but it's different from the original and I trully don't know how could I make it looks equal.
I had some problems with the menu. I don't know if the hover effect is the better one for this case. And i'm still thinking about the Mobile Menu Dropdown. I still think it coul be better. But even so, I'm proud of it, cause I think I did a good job with this Dropdown.
Now thinking about my own architecture. What do you think about the way I used the Components and the Styled Components? I get this architecture in part cause of one of my friends. He use it this way and I thought it could be a good idea.
Besides all of it, any tips? I really want to improve even more.
Community feedback
- @YevgeniyMakkaveevPosted about 3 years ago
I don't know if it is a good idea or not, but i use one class just for the geometry, and make another style for the color. With it you can make just one file for the color that will apply to all app and you don't have to pass color props too all your components. It works for me in Sass, but i think it will work fine without it even on pure css. But I came here just to learn css tricks, so I am curious too about the right way. Also you may want to close the previous menu on a header when you open the other, but I guess it’s just me, who don’t like to open many things at the same time. The layout is readable even with all of the tabs open. And thanks for an example how style components and typescript work! Good luck and happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord