Any suggestions on possible improvements are welcome.
Yannis Haismann
@YannisHaismannAll comments
- @mewebbieSubmitted over 3 years ago
- @AidenM99Submitted over 3 years ago
Feedback is welcome.
@YannisHaismannPosted over 3 years agoSeems perfect :O Good job !
Maybe to challenge yourself try to do a transition between dark and light mode :)
0 - @Jose-Angel-ReySubmitted over 3 years ago
Hi everyone, any feedback to improve my code is really appreciated 🙏🏼👨🏼💻
@YannisHaismannPosted over 3 years agoWow i really love how elements appears with animations ! Well done (I will try to do the same when i will do this challenge) :p
Just one advice from my feelings. The elements take a little to much time to appears remove some ms and that's will be like perfect.
Keep working on your code !
Marked as helpful0 - @charles-loehleSubmitted over 3 years ago
Did anyone else struggle as much as I did with this one? The navigation was a beast. Dang!
@YannisHaismannPosted over 3 years agoHey that's seem to be a good job but your pics are not visible in all width. Take a look ;)
0 - @b-meetSubmitted over 3 years ago
It seemed to be very easy at first sight but, the navigation bar literally came out to be the villain 😅😂. It was a very nice experience, I would love to take more challenges. How was your experience with this challenge guys? and Which part seemed to be easy but, was tough for you?😅😂😂
@YannisHaismannPosted over 3 years agoHey, first great job, that's very close of the illustration. I see two things you need to work on. 1- I'm on a 3440x1920 device (21/9) and the website is not responsive for my screen.(try it yourself to see the problem) 2- More an advice than a problem, that can be easier to navigate on nav if we can click somewhere else and the menu reply itself.
Sorry for my english, keep working on your code that's very cool to see that was a nice experience for you :)
0 - @iadefidipeSubmitted over 3 years ago
This is my 2nd project applying DOM manipulation. I learnt how to use the intersection observer property. The mobile dropdown and desktop nav functionality is not as perfect as i want it to be yet, so I will appreciate feedback on what i could do to make my script better.
I will appreciate feedback
@YannisHaismannPosted over 3 years agoHello first of all, really great job !
The website is responsive and work on phone and desktop that great but i have one problem. For my part i'm on a 21/9 screen and when the website is on fullscreen images are getting weird. Take a look on that.
And for the background of the header, i think you done a background linear top to bottom or something like that but try a left to right.
I'm french so sorry for my enflish.
Keep working on you code ! ;)
1