Skip to content
OverviewSolutions
28
Comments
22
Mirza Monirul Alam
@WebDevMirza

All comments

  • Mirza Monirul Alam•680
    @WebDevMirzaPosted almost 2 years ago

    Hi,

    To validate a form in react, you can use formik and yup package. They are easy to use and have enough resources in docs on how to apply to a project.

    Thank you.

    Marked as helpful
    1
  • Mirza Monirul Alam•680
    @WebDevMirzaPosted almost 2 years ago

    Hi,

    I skim through your code line by line. I want to share my views.

    HTML

    • You use picture source combination to deal with device oriented pictures which is the best in my opinion. 👍 👍

    I also found some areas where you can improve your code.

    HTML:

    • Give a <h1></h1> with small font size to solve Page should contain a level-one heading warning.
    • Provide an alt text for image to solve Images must have alternate text error.

    CSS:

    main {
    ........................
    ........................
    letter-spacing: 0.05em;
    line-height: 1.6;
}
    • Add this two line of code and observe the change. Spacing is important to improve design.

    Apart from this, the rest of the part is great.👍 I hope, this might help you. 👍👍👍

    Thank you.

    0
  • Tiago R. Oliviera•40
    @tiago-roSubmitted almost 2 years ago

    Hi, I'm Tiago. This is my solution for the product preview card component

    Built With:

    • HTML
    • CSS
    • Flexbox

    Feel free to To give sugestions/ feedback. Thank you!

    Responsive page using flexbox

    1
    Mirza Monirul Alam•680
    @WebDevMirzaPosted almost 2 years ago

    Hi,

    Congratulation on this solving this project.

    • You do not need alt text inside source tag.
    • Use alt tag in img.
    <picture>
        <source media="(min-width: 376px)" srcset="images/image-product-desktop.jpg" >
        <img src="images/image-product-mobile.jpg" alt="Perfume Channel Gabrielle">
      </picture>

    I hope that it might help you. 👍

    Thank you.

    Marked as helpful
    1
  • link-din•10
    @danilo-easy33Submitted almost 2 years ago

    I had difficulty making the background of the body, the image moves with the zoom, and I had difficulty because it came with two images.

    CHALLENGE HUB Profile card component

    1
    Mirza Monirul Alam•680
    @WebDevMirzaPosted almost 2 years ago

    Hi,

    Congratulation on completing this project. You have already found a problem regarding bg-image.

    HTML:

    • Every html should have a main tag that you have not applied. Wrap everything inside <main></main> to solve accessibility WARNING that you have now. main is used for the unique part of the site where any repeated sections such as nav, sidebar, footer are not allowed. For more info visit W3 School

    CSS 🙂

    body {
  background: url(../img/bg-pattern-top.svg) no-repeat right 50vw bottom 40vh,
    url(../img/bg-pattern-bottom.svg) no-repeat left 50vw top 54vh;
 background-color: hsl(185, 75%, 39%);
}
    • This will add the background images at the position that they should be. 🧐

    Apart from this, the rest of the part looks nice.👍

    Marked as helpful
    0
  • Kaique•40
    @KaiqueNeresSubmitted almost 2 years ago

    I had difficulty making the background of the body, as it came with two images, and I could not position myself equal to the challenge.

    Initially I had difficulty with the color of the border below the name of the city, because I was not getting the color tone right, but I managed.

    CHALLENGE HUB Profile card component

    1
    Mirza Monirul Alam•680
    @WebDevMirzaPosted almost 2 years ago

    Hi,

    Congratulation on completing this project. You have already found a problem regarding bg-image.

    HTML:

    • Every html should have a main tag that you have not applied. Wrap everything inside <main></main> to solve accessibility WARNING that you have now. main is used for the unique part of the site where any repeated sections such as nav, sidebar, footer are not allowed. For more info visit W3 School

    CSS 🙂

    body {
  background: url(../img/bg-pattern-top.svg) no-repeat right 50vw bottom 40vh,
    url(../img/bg-pattern-bottom.svg) no-repeat left 50vw top 54vh;
 background-color: hsl(185, 75%, 39%);
}
    • This will add the background images at the position that they should be. 🧐

    Apart from this, the rest of the part looks nice.👍

    Marked as helpful
    0
  • Mirza Monirul Alam•680
    @WebDevMirzaPosted almost 2 years ago

    Hi,

    I found several issues where you can improve your code.

    HTML:

    • Wrap everything inside <main></main> to solve accessibility WARNING that you have now. main is used for the unique part of the site where any repeated sections such as nav, sidebar, footer are not allowed. For more info visit W3 School
    • Give a <h1></h1> with small font size to solve Page should contain a level-one heading warning.

    CSS

    p {
    font-size: 15px;
    text-align: center;
    color: hsl(220, 15%, 55%);
    padding: 10px 25px;
}
    • You can use shadow in .card for good appearance:
    .card {
       box-shadow: rgba(0, 0, 0, 0.1) 0px 1px 3px 0px, rgba(0, 0, 0, 0.06) 0px 1px 2px 0px;
}

    Best of Luck. 👍 Thank you.

    0
  • Chanawin Kamolpanus•350
    @Chanawin-kmpnSubmitted almost 2 years ago

    In this project, I took a previous mistake and made it better in terms of unit usage and layout. If anyone can give advice or improve any part, you can give me a feedback. Thank you.

    Column preview card using Flexbox

    1
    Mirza Monirul Alam•680
    @WebDevMirzaPosted almost 2 years ago

    Hi,

    HTML:

    • Instead of using button for navigating to another page, <a></a> is the best approach. button is mainly use for submitting data to the server.
    • Wrap the entire attribution with <footer></footer> to solve accessibility warning that you have now.
    <footer>
   <div class="attribution">
         Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>.
         Coded by <a href="https://www.frontendmentor.io/profile/Upond">Chanawin Kamolpanus</a>.
   </div>
</footer>

    CSS

    • add the following code for button for a hand cursor 👆.
    button {
    cursor: pointer;
}
    • You may add some transition effect for better UX.
    button:hover {
    color: hsl(0, 0%, 95%);
    border: 2px solid hsl(0, 0%, 95%);
    background-color: transparent;
    transition: all 0.25s 0s linear;
}

    The rest of the part is fine. Well done. Keep the good work on. 😃 👍

    Marked as helpful
    1
  • Felipe Carpes•10
    @felipecarpesSubmitted almost 2 years ago

    QR Code component: responsive card containing QR Code that redirects to frontend mentor page

    QR Code component

    1
    Mirza Monirul Alam•680
    @WebDevMirzaPosted almost 2 years ago

    Hi,

    I found an area where you can improve your code.

    HTML:

    • Wrap everything inside <main></main> to solve accessibility WARNING that you have now. main is used for the unique part of the site where any repeated sections such as nav, sidebar, footer are not allowed. For more info visit W3 School
    • Give a <h1></h1> with small font size to solve Page should contain a level-one heading warning.
    • Provide an alt text for image to solve Images must have alternate text error.

    CSS

    .qr-img {
      height: 250px;
      width: 100%;
      border: 1px #000 solid;
      border-radius: 0.625rem;
    }
    • No need to use border: 1px #000 solid; since the provided design has no border.
    • You can use shadow in .card for good appearance:
    .card {
       box-shadow: rgba(0, 0, 0, 0.1) 0px 1px 3px 0px, rgba(0, 0, 0, 0.06) 0px 1px 2px 0px;
}

    Apart from this, the rest of the part is great.👍👍

    1
  • Pavlo Ivanichenko•10
    @pashaprotonSubmitted almost 2 years ago
    • I'm not good at HTML and CSS so the most difficulty was understanding is it the right solution or not
    • Everything
    • Yes, I do have questions about best practices and I would like to get feedback on how I can improve my code

    The very first challenge, QR code component

    3
    Mirza Monirul Alam•680
    @WebDevMirzaPosted almost 2 years ago

    Hi,

    I found an area where you can improve your code.

    • Put everything inside <section></section> to <main></main> to solve accessibility WARNING that you have now. main is used for the unique part of the site where any repeated sections such as nav, sidebar, footer are not allowed. For more info visit W3 School

    Apart from this, the rest of the part is great.👍

    Marked as helpful
    1
  • Mirza Monirul Alam•680
    @WebDevMirzaPosted almost 2 years ago

    Hey,

    Good work on that. On desktop version, it looks great. But in mobile version, the design is not the same as it should be.

    • Reduce spacing on both side (left and right) for the mobile version.
    • Add cursor: pointer; on button and icons.

    Rest of the part is fantastic. Keep the good work on. Hopes this might help you.

    Thank you.

    Marked as helpful
    0
  • Mirza Monirul Alam•680
    @WebDevMirzaPosted almost 2 years ago

    Hey,

    Great coding on this project! I have noticed something missing on this project. Your card__heading, and .name class have no cursor pointer. My suggestion is to add the following code:

    .name:hover, 
.card__heading:hover {
    cursor: pointer;
}

    I hope this might help you. Keep the good work on. 👌 Thank you.

    Marked as helpful
    0
  • Mirza Monirul Alam•680
    @WebDevMirzaPosted almost 2 years ago

    Hey,

    • use div container and set max-width: 375px
    • use margin: 0 auto to center
    • change your strategy for mobile first. Then desktop. It seems easy to use.
    • use media query breakpoint at 768px or 640px

    html part is good. You can make better css by improving. I hope this might help you. Thank you.

    0