Hi everyone, excited to have completed by first challenge. It'd be great if anyone has time to review and give me some feedback, whether my code is bloated in places like divs or redundant css for example. That way i can take this advice into my next challenge :)
Many thanks John
Hello @Joinx83! Good Job BTW. I saw your code and I think you can improve CSS coding using Mobile-first approach. You should focus on Responsive Web Designs. I hope these suggestions might help you. And you can use CSS custom properties (https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties). Your overall coding is great though and you can improve your current design more. Have a great time! Good Luck with your Coding Journey.👍👏😁
Hi @Hendra-Agil! Your design is great. Although, you can add a little bit of top margin to the component. One thing you have to work on is responsive web design. Your button transition is awesome but it is not appearing as it should be. Good Luck with your Web Dev Journey. Have a great time! Happy Coding! 👍👏🤩
Still need to go through the basics of CSS. only had a brief intro that did not included grid which was I think it was essential to get to the layout. I am sure I dont get the images placement right. but wasn't able to manage it other way.
need to dive into CSS
Great Job @Catarinafs! I walked through your code and you did right. One thing I noticed was you placed the footer element outside of the body element, which is not a good practice. And as @Rfilenko said, you should work on the responsive design. One thing for sure is you did everything almost perfect although beginning with CSS3 advanced topics. Have a great time! Happy Coding! 👍🤩👌😄
Que tal chicos, les presento mi proyecto en Frontendmentor, les agradecería criticas sobre la estructura y funcionalidad de mi código. Espero sus comentarios y muchas gracias.
Hi guys, this is my Frontendmentor solution, and i want to know what do you tihink about my code, structural and funcional. Thanks for all the coments and views!
Great Job NeradoOne! I like your animation. It is awesome and your design is also beautiful. I think you can improve your code structure by using a mobile-first approach and you can organize your code by making them in increasing order of their media-query width. And the font-family you put in the :root selector should be in the body I guess. But this is your choice of coding style. These are my opinion though. Have a great day!👍😄👌😁
Great Job MosesUmuomo! If you want, you can try to improve the design by making the body total viewport height (100vh). All the best with other challenges! 👍🥳🤩
Any feedback is greatly appreciated!
This is the first time I tried mobile-first. If you can give feedback on that it will be awesome!
I was thinking should I have put transitions in between the testimonials? What do you think?
I viewed your designed and it is great and of course, you should add transitions. I would like to recommend that you should use background-image and its sibling properties altogether using only background property. It reduces the code and makes more clear. Have a great day and enjoy coding! 🥳👍
I would the community to review my project and tell areas i need to work on
I saw your code @delat22 and your got the design in very less code. That's great. If you increase the width of the main container element for the mobile, it will look a lot more better. But you achieved the challenge in less code than me. Have a great day!🤩👍🥳
Your design is almost similar to the original one. That's great. Your button's colour is a little bit dull. You can use the one provided in the style-guide.md. All the best.🤩
I used a div and span to visualize the data storage amount instead of range or progress. You can try that and here is my repo link if you like to view it. https://github.com/VijayKumarKTG/fylopersonalstorage I hope this might help you.
