HTML and CSS

Community feedback

• 

  Vijay Kumar•260

  @VijayKumarKTGPosted over 4 years ago

  Great Job @Catarinafs! I walked through your code and you did right. One thing I noticed was you placed the footer element outside of the body element, which is not a good practice. And as @Rfilenko said, you should work on the responsive design. One thing for sure is you did everything almost perfect although beginning with CSS3 advanced topics. Have a great time! Happy Coding! 👍🤩👌😄

  1

  ---

  

  Catarina•35

  @catarinafsPosted over 4 years ago

  @VijayKumarKTG many thanks for you review. When you say responsiveness it is defining the @media right? i tried to only define to mobile it was hard 🤔

  1

  

  Vijay Kumar•260

  @VijayKumarKTGPosted over 4 years ago

  @catarinafs! Yeah, it was also a little hard for me at the beginning, but I'm sure that you will get it soon. Good luck!🤩👍

  0
• 

  Roman Filenko•3,335

  @rfilenkoPosted over 4 years ago

  Hi, overall good, but you can improve a little bit:

  • semantic html, sometimes overuse of divs;
  • flexbox or grid can be use to position elements inside .card, for example;
  • work more on responsive beyond mobile view.

  Keep coding😉, Roman

  0

  ---

  

  Catarina•35

  @catarinafsPosted over 4 years ago

  many thanks for the assessmente. I knew nothing about grid before the challenge and still hasnt got to flexbox... looks like my life will be a bit easir when I understand how to use those well. Just started to code HTML/CSS max a week ago.

  0
• 

  Jhoan Beron•0

  @jmberonPosted over 4 years ago

  Very good, well done!

  0