All comments

• 

  Mario Pavlović•130

  @MarioPavlovic156Submitted almost 5 years ago

  All feedback is welcome!

  

  HTML and CSS, FLEXBOX and GRID

  2

  00
  

  TishG•205

  @TishGPosted almost 5 years ago

  Hi Mario,

  I recommend taking a look at your body width and element heights and widths. A lot of elements are out of place both on mobile and desktop.

  2
• 

  mbcod3•515

  @mbcod3Submitted almost 5 years ago

  I used picture tag for display curved images for three sections. Is it bad to use html element for such images?

  

  Mobile First Site Using Custom Framework

  3

  30
  

  TishG•205

  @TishGPosted almost 5 years ago

  You have nearly perfected the mockup. Great work!

  Not sure if it shows this on your screen but on my device, the button in the footer is not styled.

  

  2

  This comment has received 2 repliesShow
• 

  Clinton•260

  @DarkFMSubmitted almost 5 years ago

  I designed the site to update the URL query strings as the user adds filters (search and Region) but because github pages server does not support History API. So I had to use HashRouter.

  Feedback on structure and design choices are welcome as this is my first proper react project. I tried to stay true to the original design. As laid out in the design files.

  

  React with React-Router, SASS. Used CSS variables for theming.

  2

  20
  

  TishG•205

  @TishGPosted almost 5 years ago

  Your app looks great. I like the transition effect when switching between light mode and dark mode.

  I don't know if you notice this or are working on it at the moment but the search functionality does not work.

  0

  This comment has received 1 replyShow