Skip to content
Submitted almost 5 years ago

Mobile First Site Using Custom Framework

mbcod3•515
@mbcod3
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Huddle landing page with curved sections
  • HTML
  • CSS
2junior

Design comparison

SolutionDesign

Solution retrospective

I used picture tag for display curved images for three sections. Is it bad to use html element for such images?

Community feedback

  • TishG•205
    @TishGPosted almost 5 years ago

    You have nearly perfected the mockup. Great work!

    Not sure if it shows this on your screen but on my device, the button in the footer is not styled.

    image

    2
    mbcod3•515
    @mbcod3Posted almost 5 years ago

    @TishG What device and browser are you using?

    0
    mbcod3•515
    @mbcod3Posted almost 5 years ago

    @TishG You are right on android phone in chrome browser footer button is not being styled. The reason is because I changed button type to submit on html but not in style.css. Now its fixed.

    Great catch btw

    0
  • mbcod3•515
    @mbcod3Posted almost 5 years ago

    Thank you

    0
  • Matt Studdert•13,611
    @mattstuddertPosted almost 5 years ago

    Nice work! For the curved images, I'd typically go with a background-image in the CSS for these as they're purely decorative. But using an img element is fine as long as the element is hidden for screen reader users through a blank alt attribute or the aria-hidden="true" attribute.

    Keep up the great work!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord