All comments

• 

  shrey dhawan•145

  @shrey1799Submitted over 4 years ago

  im a newbie to HTML and CSS and i would really appreciate any comments on the layout, overall appearance or how could i have made my code better.

  thank you !!😊

  

  four card feature section using HTML and CSS

  4

  10
  

  TCassas•235

  @TCassasPosted over 4 years ago

  Small contribution, instead of using <div class="header"> you can use the <header> tag!

  1

  This comment has received 1 replyShow
• 

  Jaspreet Singh•50

  @Jassi3045Submitted over 4 years ago

  Any change required??? Please tell me!!!

  

  Challenge done with HTML and CSS

  1

  00
  

  TCassas•235

  @TCassasPosted over 4 years ago

  Something I noticed is that you have some extra space at the right side of the entire project, maybe adding "overflow-x: hidden;" somewhere will fix it. Leaving that aside, the desktop version looks pretty neat!

  Don't leave mobile version aside!!

  0
• 

  Jhabari Guidry•190

  @J-GuidrySubmitted about 5 years ago

  Should there have been css attribute selectors used in CSS for aria attributes instead of classes which is toggled in js? I could not completely get a match on background blue color after/before pseudo selector although I got as close as I could. Was height percentage along with the rest of the code a good way to get that done (css lines 178-190, 286-297)? I spent a lot of time researching accessibility. I am unsure it was done right in the tabbed system and accordion. Was the error system on the form under the action done correctly? the red around the input sounds like there was a div surrounding it which I did use with display none.

  

  flexbox for some sections, mobile overlay, inline-flex

  3

  20
  

  TCassas•235

  @TCassasPosted about 5 years ago

  You can use the "transition" css attribute to make those effects as smooth as you want!

  1