Skip to content
OverviewSolutions
4
Comments
16
Stephen Addae
@Stephen-Adom

All comments

  • Stephen Addae•270
    @Stephen-AdomPosted about 2 years ago

    @jadetrue, you forgot to implement the mark all read action

    0
  • Stephen Addae•270
    @Stephen-AdomPosted about 2 years ago

    Hello @jadetrue, the app looks good on tablet and desktop screens but not mobile. With tailwind utilities, you can easily design the mobile version of this app.

    0
  • blackbottt•60
    @BlackbotttSubmitted about 2 years ago

    Frontend Mentors l really struggled with the responsive css for widths 375px's and less, are @media queries the only way to write responsive css? it was optional making a working scoreboard but l feel l should do it, but l was wondering is redux the only way to manage state or ?! thank you, feedback is more than appreciated.

    rock-paper-and-scissors HTML, CSS and JS

    2
    Stephen Addae•270
    @Stephen-AdomPosted about 2 years ago

    You can use redux or local storage but redux is more effective since any updates is reflected on the UI Component. With localstorage, you have to fetch the data whenever you update the store with the scores

    0
  • Stephen Addae•270
    @Stephen-AdomPosted about 2 years ago

    Hello Jorge, I don't know if you have checked but on the desktop and mobile view, the page overflows off the screen, hiding the page title and make all read link. Its okay on tablet screens though

    0
  • blackbottt•60
    @BlackbotttSubmitted about 2 years ago

    Frontend Mentors l really struggled with the responsive css for widths 375px's and less, are @media queries the only way to write responsive css? it was optional making a working scoreboard but l feel l should do it, but l was wondering is redux the only way to manage state or ?! thank you, feedback is more than appreciated.

    rock-paper-and-scissors HTML, CSS and JS

    2
    Stephen Addae•270
    @Stephen-AdomPosted about 2 years ago

    Hello blackbott, the rules button text is not centered in the button container and also the button is not centered horizontally on mobile screen. Change the text color of the selected tiles and the score title to white to make it more readable The header must show the current score when the user navigate to the home page as well. You can also apply transition to the hover effect on the tile to make the effect more natural.

    Marked as helpful
    1
  • Stephen Addae•270
    @Stephen-AdomPosted about 2 years ago

    The total amount and the tip amount value have to be updated whenever there's a change in bill field and no of people field. Also where do you get this error "must be greater than zero message".

    0
  • Stephen Addae•270
    @Stephen-AdomPosted about 2 years ago

    Hello Abdul, you forgot to implement the mark all as read toggle functionality. Also, you have to work on the mobile screen size. With the responsiveness, you can use bootstrap or tailwind

    Marked as helpful
    0
  • shikoto•1,010
    @shikot0Submitted about 2 years ago

    This is my second react solution, if there are any issues or ways to make the code more efficient or accessible.

    Country list using react

    2
    Stephen Addae•270
    @Stephen-AdomPosted about 2 years ago

    Hello shikoto, the height of your card grid must be of the same height. You can do that by setting the height of the card to 100% and add margin to the column sections. Also the image icon on the back button is not rendering On the view section, the should be some padding for the border countries list to be full display. You can increase the padding around the border countries label and add flex-wrap to the list if it overflows

    Marked as helpful
    1
  • Stephen Addae•270
    @Stephen-AdomPosted about 2 years ago

    Hello EryX, your site looks good on desktop screen need a little work on tablet and more work on mobile screens

    Marked as helpful
    0
  • Stephen Addae•270
    @Stephen-AdomPosted about 2 years ago

    Hello @Emmanuel, a single page web design like this has to have the design fit the user's viewport. I'm not sure if you have knowledge in css flexbox and grid but those can help you with your design and responsiveness. You can set the body height to 100vh to give you some constraint and set the image with using percentage to make the image size responsive across all device width

    0
  • Rico•370
    @ShuliiiSubmitted about 2 years ago

    hi it's my first project using javascript. any comments or feedback are welcome

    Calculator-Tip-App

    1
    Stephen Addae•270
    @Stephen-AdomPosted about 2 years ago

    @Shuliii Great work on the tip calculator. The bill amount field and number of people input does not update the value when there's a change in their inputs. You can apply the change event you used on the custom field on both the bill and people no inputs to recalculate the total bill.

    Marked as helpful
    0
  • Stephen Addae•270
    @Stephen-AdomPosted about 2 years ago

    hello @RobertoBaiochi, great work on your project, looks good on all device. The nav link seems to break or they are not working. With a single page website like this, I would suggest linking the nav links to their respective section on the page to implement the smooth scrolling effect when a user navigate your site.

    Marked as helpful
    1