Design comparison
Community feedback
- @Stephen-AdomPosted about 2 years ago
Hello EryX, your site looks good on desktop screen need a little work on tablet and more work on mobile screens
Marked as helpful0@EryX0Posted about 2 years ago@Stephen-Adom hey, thanks for your comment, would definitively work on it if I got the time.
0 - @correlucasPosted about 2 years ago
👾Hello @EryX0, Congratulations on completing this challenge!
Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:
You did a really good work here putting everything together, something you can improve its your code html markup and semantics. You can replace the
<div>
that wraps each card with<article>
you can wrap the paragraph with the quote with the tag<blockquote>
this way you'll wrap each block of element with the best tag in this situation. Pay attention that<div>
is only a block element without meaning.This article from Freecodecamp explains the main HTML semantic TAGS: https://www.freecodecamp.org/news/semantic-html5-elements/
✌️ I hope this helps you and happy coding!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord