All comments

• 

  Krzysztof Pawłowski•140

  @KP1976Submitted about 1 month ago

  What challenges did you encounter, and how did you overcome them?

  • The challenge was properly aligning the dots in the list of preparation time and the list of ingredients.

  

  Recipe Page

  1

  10
  

  Shayneze Menegady•120

  @ShaynezePosted about 1 month ago

  Result is very nice and similar to the design given :)

  Why do you use 2 css files?

  Some comments to improve the final result :

  • mobile version : you should remove the padding of "main" so that we don't have the beige background
  • the list elements should be the same color as the corresponding header (here they are all in dark pink)

  Also you should place the css file outside of the asset folder (at the same level as index.html)

  Marked as helpful

  1

  This comment has received 1 replyShow
• 

  Sujal Patel•90

  @DvlPrSujalPatelSubmitted about 2 months ago

  What are you most proud of, and what would you do differently next time?

  I created it my self using flex box

  

  In this I used most of the flex properties to align the links

  1

  30
  

  Shayneze Menegady•120

  @ShaynezePosted about 1 month ago

  Nice challenge :)

  It would be better to use <a> element instead of <li> since they are links to pages that can be clicked

  0
• 

  P

  Nouran Al-Sharawneh•130

  @NouranAlSharawnehSubmitted about 2 months ago

  

  Blog Card

  2

  30
  

  Shayneze Menegady•120

  @ShaynezePosted about 2 months ago

  Github repo is not accessible. (I checked it through the inspector)

  Code is well structured and readable, it's a good project. :)

  Some improvements to match better the model :

  • add border-radius on the bottom of the image
  • font size are not reduced with smaller screen size
  • too much space at the bottom of the card (below card-poster)
  • increase line-height

  Marked as helpful

  0

  This comment has received 1 replyShow
• 

  mojtaba mn•130

  @mojtaba-mehrzadSubmitted about 2 months ago

  

  noting

  1

  20
  

  Shayneze Menegady•120

  @ShaynezePosted about 2 months ago

  Good use of semantic HTML, the code is well structured and readable. The result is good

  More attention could have been paid to the design elements given in the Figma documents:

  • font in bold for the text when the template shows a regular font
  • line heigt hasn't been changed
  • default margin are still present thus the spacing is not the same as in the template
  • border radius of 15px instead of 20px for the card etc.

  Marked as helpful

  0