Shayneze Menegady• 100
@Shayneze
Posted
Github repo is not accessible. (I checked it through the inspector)
Code is well structured and readable, it's a good project. :)
Some improvements to match better the model :
- add border-radius on the bottom of the image
- font size are not reduced with smaller screen size
- too much space at the bottom of the card (below card-poster)
- increase line-height
Marked as helpful
0
P
Nouran Al-Sharawneh• 130
@NouranAlSharawneh
Posted
Hey @Shayneze, thank you for the feedback, for the font size to make it responsive, i should use rems instead of pixels? it's just that i was using the figma file and all the units are in pixels. So i should convert the units before using them? and thank you
0
