Blog Card

Community feedback

• 

  Shayneze Menegady•120

  @ShaynezePosted about 2 months ago

  Github repo is not accessible. (I checked it through the inspector)

  Code is well structured and readable, it's a good project. :)

  Some improvements to match better the model :

  • add border-radius on the bottom of the image
  • font size are not reduced with smaller screen size
  • too much space at the bottom of the card (below card-poster)
  • increase line-height

  Marked as helpful

  0

  ---

  

  P

  Nouran Al-Sharawneh•130

  @NouranAlSharawnehPosted about 2 months ago

  Hey @Shayneze, thank you for the feedback, for the font size to make it responsive, i should use rems instead of pixels? it's just that i was using the figma file and all the units are in pixels. So i should convert the units before using them? and thank you

  0
• 

  Yacoub AlDweik•970

  @YacoubDweikPosted about 2 months ago

  Habibti Nouran it looks amazing and almose a pixel perfect design! BTW I liked your GitHub Profile sooo much! but the design itself is not responsive, do not use fixed heights and widths the next time ok Habibti? Keep it up Nono!

  0