Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • P
    Matias Altier• 120

    @matiasaltier

    Submitted

    What are you most proud of, and what would you do differently next time?

    I would focus more on the similarity of the design with good semantics

    What challenges did you encounter, and how did you overcome them?

    This challenge is difficult if you don't know box-shadow

    What specific areas of your project would you like help with?

    In the semantics of my code

    Blog preview card using BEM and FLEXBOX

    1

    P
    Santiago Andres Gelvez Camargo• 40

    @SantiagoGelvez

    Posted

    It is a great project. There are some things to stay closer to the design.

    • Ensure your max-width of the class hero-container to the design on figma. Also similar to the borders and pading.

    • Use `line-height: 1.5;``in your universal selector to have a separation on the text lines.

    With these improvements I hope you project look similar to desgin.

    Related to another things like use of BEM, values in rem and use of gap, I really like the way you code.

    Marked as helpful

    0
  • Nostromito• 190

    @Nostromito

    Submitted

    What are you most proud of, and what would you do differently next time?

    The completion of the project is what I'm most proud of. Something as simple as this page gave me troubles but staying level headed, I was able to figure it out to the best of my knowledge.

    What challenges did you encounter, and how did you overcome them?

    Centering items was my biggest challenge. Figuring out the padding and and the text align was difficult to me for some reason. Once I figured out one thing I was able to space it how I needed to and kept moving from there.

    What specific areas of your project would you like help with?

    I would like help with confirmation of what I did correctly and what I could do better in my code.

    QR code by Nostromito

    1

    P
    Santiago Andres Gelvez Camargo• 40

    @SantiagoGelvez

    Posted

    Hi!

    It seems that could be good project but the image link is broken and the font is not similar to the website. But, reviewing you code, there are some tips that may help you:

    • Consider create a directory called css or styles. Is most common find this directory in large projects.
    • In google fonts, there is a way to put the link directly into style sheet. At the begining. It seems like: @import url('https://fonts.googleapis.com/css2?family=Outfit:[email protected]&display=swap');
    • The src of your image tries to access to a directory images which actually is not placed in your project. You need to create the folder images and move the image-qr-code.png into this folder.

    In sheet styles:

    • Add the line box-sizing: border-box; to get mos similar results according the design.
    • Consider user em o rem instead of px to get better performance in multiple devices.

    I hope you find usefull this tips and help you to achive the goals of the challenge.

    0
  • P
    Santiago Andres Gelvez Camargo• 40

    @SantiagoGelvez

    Posted

    Your project is amazing. But, if you want to be closer to the design, you could change the order of your styles sheet setting the file reset.css at the end of the imports. These change should fix the width of the card according to the design.

    0